chore(express): Remove deprecated enableHandshake option and req.auth property access - #7926
Conversation
Handshake is now always enabled unconditionally since API requests don't trigger handshake flow.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: d709f7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!allow-major |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR removes the deprecated enableHandshake option from the Clerk Express middleware and deletes the legacy handshake flow. It replaces direct access to req.auth with getAuth(req), updates Express.Request.auth to a function signature, removes enableHandshake from ClerkMiddlewareOptions, and deletes tests/routes relying on the legacy API. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
jacekradko
left a comment
There was a problem hiding this comment.
Let's add a change file here for this breaking change: https://github.com/clerk/javascript/tree/main/packages/upgrade/src/versions/core-3/changes
updated! thanks |
Description
This PR removes deprecated
enabledHandshakeoption and directreq.authproperty access.Resolves USER-4803
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Breaking Changes
Refactor
Tests
Documentation