Repository navigation
fix(clerk-js): Form errors not displayed when form submitted with enter - #1097
Merged
Merged
Conversation
panteliselef
requested review from
SokratisVidros and
nikosdouvlis
as code owners
April 21, 2023 14:29
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
SokratisVidros
approved these changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.This is introduced due to enableErrorAfterBlur option from useFormControl that will delay an error message from being displayed until user moves clicks away from the field at least once.
This was a necessary change I had to make, in order to support displaying error messages while typing a password, but for better UX to delay giving users feedback for the errors until they move away (only the first time).
In order to fix this, I introduced a flag that keeps track of whether the form was submitted by pressing enter inside the field. If that's the case then I bypass that the logic above and directly display the error message.