Repository navigation
docs(repo): colocate Mosaic feature tests with their component - #10076
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 8e302b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. 5 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour. 📝 WalkthroughWalkthroughThe testing guidance now says to place each feature test beside the component it renders and name it after that component. It identifies the Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The feature-test guidance matches the configured test discovery, and the empty changeset does not disrupt release status. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
…onent Follows the convention landed in #10076: a feature test lives next to the component it renders.
Description
The Mosaic testing guide now says to put a feature test next to the component it renders and to name it after that component. For example,
<UserProfilePasswordSection />is tested byuser-profile-password-section/user-profile-password-section.feature.test.tsx.Vitest finds feature tests by their
.feature.test.tsxsuffix, so the shared__tests__/folders aren't needed. They also make it hard to find a section's tests:features/user-profile/__tests__/has about 49 files. Existing tests in__tests__/folders move the next time their feature changes. They aren't moved in this PR.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change