Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 55cb988 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
7e4c5d7 to
51c30de
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…shimmer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
48eb122 to
1cf9b28
Compare
…-skeleton # Conflicts: # packages/mosaic/src/features/api-keys/api-keys-table.view.tsx
Description
Adds a skeleton for the user profile API keys panel, built on the skeletons from #10029. The skeleton is the real table view rendered with placeholder data, so it can't drift from the loaded markup.
Table.Root skeletonshares the flag with everyTable.HeaderCellandTable.Cellinside it, the same waySection.Groupdoes. A skeleton cell keeps its children as mock text insideSkeletonText, so each bar is as wide as the text it stands in for.skeleton={false}opts a cell out. The skeleton root isinertandaria-hidden.Table.Bodyalso takesskeleton, for a table that turns only its rows into bones while the header stays real.APIKeysTableViewtakesskeleton. It renders its normal rows from the data it is given, shows toolbar bones and a visually hidden loading status, and skips its create and revoke dialogs. The name cell draws its two lines (name, then id and expiry) throughSkeletonText. The date cells render their labels directly instead of throughText, so the inheritedSkeletonTextwraps plain text (no visual change to loaded rows). The actions cell draws nothing and holds the menu trigger's column width.APIKeysTableSkeletonrenders the view withskeletonand three placeholder keys of typical length.UserProfileApiKeysPanelSkeletonputs it underPanel.Title skeletonwith the page title as mock text.APIKeysTableViewalso takesrefetchSkeleton(opt-in). With it, the rows become bones whileisFetchingis set. After a page change or a sort it shows exactlymin(pageSize, totalCount − offset)rows; after a search it shows 3. Nothing passes it yet, so production behavior is unchanged: the wired table keeps its spinner andkeepPreviousDatarows until wire-up adds the delay/min-duration gate.Open question:
Previews on UserProfileApiKeysPanel:
refetchSkeletonwith a 2s fetch. Go to page 2 to see its two rows as bones.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude Code