Fix MiniMax H3 GGUF model and encoder loading - #481
Open
Gingertrout wants to merge 1 commit into
Open
Gingertrout wants to merge 1 commit into
Gingertrout wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MiniMax H3 I2V fails before sampling: Qwen3-VL-32B GGUF loading omits the vision projector, so ComfyUI selects Mistral and raises
TypeError: the JSON object must be str, bytes or bytearray, not NoneType. MiniMax diffusion GGUFs without architecture metadata also fail detection.Load and map the matching Qwen3-VL projector, including temporal patch embeddings and DeepStack mergers, and preserve the native key layout used to detect MiniMax's 32B encoder. Add MiniMax diffusion architecture recognition. Keep Qwen2-VL loading and smaller Qwen3-VL text-only workflows working; report a missing 32B projector directly.
Validation:
minimax_h3_fl2va_pruned-Q4_K.gguf,Qwen3VL-32B-Thinking-Q4_K_M.gguf, and its matching Q8_0 projector; ComfyUI 0.36.0 (a2f455c9), PyTorch 2.9.1+cu128. This verifies execution, not equivalence to the reference Instruct encoder's output quality.Related: #473, #476, #478, #480. This provides a small combined alternative against
mainwith regression coverage for both failures. Please consider it for an upcoming release.