Skip to content

Tidy up - #33

Closed
arafune wants to merge 1302 commits into
chstan:masterfrom
arafune:tidy_up
Closed

arafune wants to merge 1302 commits into
chstan:masterfrom
arafune:tidy_up

Conversation

@arafune

@arafune arafune commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

No description provided.

arafune added 30 commits June 16, 2024 22:17
arafune added 29 commits March 8, 2025 11:27
* ⚡️ Remove cut_nan_coords, drop_nan

These can be substituted by dropna method (standard xarray method)
🔨  Refactoring trapezoid.py (c1 -> left_lower ...)

* 🔨  By introducing rectangle_phis more, we can apply trapezoid coorection is now switchable for from/to trapezoid

🔨  ConvertTrapezoidCorrection.get_coordinates is updated.

🚚  trapezoid.py is moved to correction, and rename apply_trapezoid_correction to trapezoid

✅  Add test for trapezoid.py
* 💥  Update kz_conversion.py and bump up the version to 5.0.0-pre3

The following should be fixed in the next (pre-)relase:
src/arpes/analysis/self_energy.py	0.00%	9 Missing ⚠️
src/arpes/correction/fermi_edge.py	11.11%	8 Missing ⚠️
src/arpes/analysis/gap.py	0.00%	4 Missing ⚠️
src/arpes/fits/fit_models/functional_forms.py	60.00%	4 Missing ⚠️
src/arpes/utilities/conversion/forward.py	0.00%	4 Missing ⚠️
src/arpes/analysis/band_analysis.py	0.00%	3 Missing ⚠️
src/arpes/bootstrap.py	40.00%	3 Missing ⚠️
src/arpes/fits/fit_models/fermi_edge.py	33.33%	2 Missing ⚠️
src/arpes/plotting/spatial.py	0.00%	2 Missing ⚠️
src/arpes/_typing.py	93.75%	1 Missing
🔥  Remove fermi_dirac definition, which is already defined in fit_models
🔥  Remove math.py

✅  Add test for analysis.general.py
* 📝  Update ipynb

* 🎨  Revise make_overview a bit.

* 🔨  Refactoring switch_angle_unit and switched_angle_unit

* 💚  Remove ruff error.

* 🐛  Fix bug in intensity_map.shift_by

* 🚚  In order to prevent PCL0415, following steps has been inprementd.

  🚚  Move ScanDesc to _typing.py

  🚚  Move load_scan to io.py

  🚚  EndstationBase moves to endstation/base.py

  🚚  FITSEndStation moves to fits_endstation.py
    🔨  Move two abstract classes to base,py
    🔨  Move function for registry plugins
    🔨  Move SingleFileEndstation etc.

* 🔥  Remove DOCS_BUILD global variable

* 🔨  Refactoring to prevent circularly import.

Still not 100% coverage by this change

  * Make config.initialize
  * Make setting.py
  * Make plugin_loader.py

However, still several ruff error remains. So,
🎨  add noqa tag

* 🎨  New function: waterfall_dispersion, which will includes stack_plot_dispersion & more.
  🎨  stack_dispersion_plot and flat_dispersion_plot are set deprecated.
  ✅  Includes unit test for waterfall_dispersion

* ✅  Add test for waterfall_dispersion

* 🎨  Add prune arg for waterfall_dispersion

* ✅  Update test for waterfall_dispersion

* ✅  More test for intensity_map.py

* 🔥  Add tag of "Deprecated" for analysis.general.condense

* ✅  Add test for plugins/registry.py

* 🔨  Docstring arpes.__init__ is Update

src/arpes/endstations/base.py	59.09%	72 Missing ⚠️
src/arpes/endstations/ses_endstation.py	34.14%	54 Missing ⚠️
src/arpes/endstations/fits_endstation.py	74.64%	36 Missing ⚠️
src/arpes/endstations/single_file_endstation.py	73.91%	6 Missing ⚠️
src/arpes/setting.py	68.75%	5 Missing ⚠️
src/arpes/endstations/plugin/Phelix.py	33.33%	2 Missing ⚠️
src/arpes/io.py	91.66%	2 Missing ⚠️
src/arpes/workflow.py	50.00%	2 Missing ⚠️
src/arpes/plotting/spatial.py	66.66%	1 Missing ⚠️
* 🎨  Introduce ConfigManager to remove glabal variables.

💥 New feature: introducing SmoothingApp to smoothing interactively
* ✨  Bump up the version 5.0

* 🎨  TaylorApp is added.

* ✅  Add test for ui.combine.TaylorApp

* ✅  Add tiny test for ui.fit.py

* 🎨  Build ProfileApp

  🎨  Use ProfileApp for S.show(), which is better because coordinates
  are shown.

* 🎨  Add helper function.

* 🎨  Use profile_curve function for SmoothingApp

* 🎨  Add new function normalize_max

🎨  Update SmoothingApp (add new function, (2nd derivative through SG filter)

* 💚  Fix ruff error.

* 🎨  Update App

* ⚡️  Split xarray_extensions.py into several libraries.

* 🎨  2nd derivative -> nth derivative (n<=6)

* refactor: 💡 _typing.py is split into several files

* feat: 🎸 follow split _typing

* feat: 🎸 Move several object into _typing

* chore: 🤖 update pyproject to ignore files in _typing

* 🔨  Refactoring build_crosscorrelation

* 🔨  Refactoring prodigy_itx

  🎨  Divide prodigy_itx and prodigy_sp2

  🎨  Add _helper in endstations.

* 🎨  Add new helper function as_angle for prodigy_itx file.

* fix: 🐛 Remove the entry normalized_relative_change from api.rst

* 🎨  if angle is already deg, do nothing.

* 🔧  Update to follow the recent change of uv.

* 💡  Add my paper
@arafune arafune closed this Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants