Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying quickadd with
|
| Latest commit: |
eae4cd5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://14a83b0a.quickadd.pages.dev |
| Branch Preview URL: | https://prototype-fill-form-from-tex.quickadd.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one-page input form gets a Fill from clipboard button. It sends the clipboard text, the field list, and the choice's destination (the Capture format, or the Template's file name and body) to the AI Assistant's default model. It asks for one string per field using the existing schema-constrained
Agent.generate, then types each answer into its field. The form's own parsing, date handling, and file-name preview apply as usual. Nothing is written until the user clicks Submit.Why
{{VALUE}}appears in 196 of 404 vaults with choices. Scripts that fetch metadata to fill a template are among the most common user scripts (movies.js,bookfromdouban.js, Google Books).Behavior
The button shows only when AI features are on, a Default model is set (not Ask me), and the form has fillable fields. Vault file pickers and sliders stay manual.
It fills empty fields and fields still showing their default. Text the user typed is kept.
A field used in a file name gets a "no
: / \ # ^ [ ] |" hint. Before that hint, the model produced a title with a colon, and the existing file-name preview flagged it before anything was written:Demo (real Obsidian 1.13.7, real
gpt-6-lunacall through the OpenAI provider)A pasted chat filling a Meeting note (2-4 s per fill in my runs):
Try it
gh pr checkout <this PR> && pnpm install && pnpm run build, then reload QuickAdd.{{VALUE:name}}fields. Set its One-page input override to Always, or turn on one-page input globally.What's faked or unfinished
Agent.generaterunspromptthrough the QuickAdd formatter. That formatter would expand the destination's{{VALUE:...}}placeholders (it opened date prompts in testing) and any tokens in the clipboard (the same class as issue 1927). A real version needs an internal literal-prompt path onAgent.quickaddandquickadd-cli. The review-before-submit step exists for this.Note
Add clipboard-based AI form filling to one-page preflight inputs
OnePageInputModalthat sends clipboard text to the configured default AI model and fills only fields that are empty or still at their default value__-prefixed and file-picker fields) and includes Capture/Template destination context, capped at 4000 characterstypeIntoFielduses the nonstandardinput.instanceOf(HTMLSelectElement)property, which may fail TypeScript compilation or runtime checks before event dispatch; marked as a prototype not for merge in the PR title📊 Macroscope summarized eae4cd5. 5 files reviewed, 5 issues evaluated, 2 issues filtered, 3 comments posted
🗂️ Filtered Issues
src/preflight/OnePageInputModal.ts — 3 comments posted, 4 evaluated, 1 filtered
dropdownwith no options is included inemptyand sent to the model, but its renderer disables the select and never installs anonChangehandler. When the model returns a nonempty value,typeIntoFieldcannot publish it toresult, whilefilledstill counts it and the success notice incorrectly says that field was filled. Exclude disabled/optionless dropdowns from the fill request/count. [ Out of scope (post-validation triage) ]src/preflight/createFillFromText.ts — 0 comments posted, 1 evaluated, 1 filtered
defaultModelRefis used whenever it exists, without confirming that itsnamestill equalsdefaultModel. A persisted stale ref is explicitly supported elsewhere as inert; here it instead sends the request to the stale provider/model even after the user has changed the visible default model. [ Previously rejected ]