Repository navigation
test(e2e): allow time for the second playback checkpoint - #424
Merged
Merged
Conversation
chhoumann
marked this pull request as ready for review
October 12, 2026 22:04
Deploying podnotes with
|
| Latest commit: |
e41cbb4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b0f22538.podnotes.pages.dev |
| Branch Preview URL: | https://test-j-play-11-deadline.podnotes.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
J-PLAY-11 waited 20 seconds for a saved position of at least five seconds, but that value reaches disk on the second write, about 20 seconds after the episode click. Allow 30 seconds while keeping
>= 5and the later restore assertions unchanged.Use two playback observations separated by
sleep(gapMs)for playing episodes; retain continuous checks while paused. Remove the offline request-count assertion against a stopped server, and replace the future-schema readiness sleep with a wait for its rejection notice. Four test files only.Verification
At
e41cbb4a964580b5ad5af3d23c199360d112efae, based on masterab4b07c:npm run lint,npm run format:check,npm run typecheck,npm run build,npm run test,npm run test:tooling, andnpm run docs:buildpassed. Application tests: 1,714 in 99 files. Tooling: 10 tests. Svelte: zero errors or warnings. Docs: all links and 112 legacy fragments valid.npm run test:e2epassed 77/77 on 1.14.4;PODNOTES_OBSIDIAN_APP=/opt/Obsidian/obsidian npm run test:e2epassed 77/77 on 1.13.7.npm run test:e2e -- tests/e2e/journey-playback.test.ts -t J-PLAY-11passed five consecutive runs on 1.14.4, each with a fresh instance. Disk traces show the qualifying write about 20 seconds after the episode-selection write. The test uses the local Journey Playback feed and its 60-second Long Listen WAV.npm run test:e2e -- -t '#355 audio keeps playing'. It failed the expected advancement assertion, 0.521333 seconds against the required 1 second. Source was restored before all gates and full suites.All commands used Node 22.23.2. No retries. All owned instances stopped. Report and logs, traces, mutation capture and hashes.
Release impact
None. Tests only; no product, navigation, storage, API, or URI changes.
Fixes #421
Note
Fix e2e test timing: extend playback checkpoint wait and replace fixed delays
playbackOverin library.ts to wait the full requested interval before the second observation when playback is already active, instead of polling for an immediate state changeMacroscope summarized e41cbb4.