Repository navigation
chore(deps): resolve development dependency security alerts - #402
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve all six open Dependabot alerts and the additional fast-uri advisory in development dependencies. Both the root and docs audits report zero vulnerabilities. The production plugin bundle is byte-identical.
Upgrade Obsidian to 1.14.4, which declares patched Moment. The latest linter still pins an older Obsidian package, so its Moment dependency needs a scoped override. The latest obsidian-e2e still requires a vite-plus version that pins vulnerable oxfmt. Override that formatter with the project's existing patched oxfmt through
$oxfmt. This removes the obsolete formatter and its native bindings. Remove the obsolete brace-expansion overrides and refresh compatible brace-expansion and fast-uri versions.Obsidian requires newer CodeMirror peers and separate copies of the linter's older peers. CodeMirror remains external to the bundle. PodNotes uses
vite-plus/testthrough obsidian-e2e and never runsvp; that test entry does not use oxfmt. Remove the Moment override when the linter ships patched Moment. Remove the formatter override when obsidian-e2e permits a vite-plus release whose formatter already uses patched Tinypool.The advisory evidence follows. All paths start at PodNotes.
<=2.1.0<2.1.2>=2.29.2 <2.31.0<1.1.21>=2.0.0 <2.1.7>=4.0.0 <5.0.12>=3.0.0 <3.1.8, moderateBrace-expansion and fast-uri already fit their parents' declared ranges, so they need no new overrides or parent upgrades. Docs contains none of the four affected packages and its lockfile is unchanged. Unrelated lock entries, including
libc, stay intact.Verification
npm ci,npm ls tinypool moment brace-expansion fast-uri,npm ls --all, rootnpm audit, andnpm audit --prefix docspass. Both audits report zero vulnerabilities.npm run lint,npm run format:check,npm run typecheck,npm run build,npm run test, andnpm run docs:buildpass. All 86 unit test files and 1,386 tests pass. Docs builds 15 pages, validates internal links, and resolves 73 legacy fragments.npm run sizepasses at 314,794 raw bytes and 99,368 gzip bytes.cmpconfirms byte equality with the pre-change bundle. SHA-256 is296b01118a4530ead44ac42ce552011867859a07e1bdc1963840a3c1da8a729f.npm run test:e2epasses all 11 files and 53 tests in isolated Obsidian 1.13.7 on headless Linux, vaultpodnotes-chore-dependabot-alerts. The suite uses local fixture feeds and WAV audio, covers playback, URI, local-file, sync, popout, and quit persistence, and restores fixture state. The instance is stopped, and the stop dry-run reports no PIDs.PodNotes imports neither Moment nor the other affected packages. Obsidian is external to the bundle, and PodNotes uses its own date formatter. The isolated app supplies
window.moment2.30.1 independently of the development package. Updating the lock does not replace the host's Moment.Release impact
The current public Obsidian version is 1.14.4. Both the desktop and mobile changelogs mark the October 5 release as public. The stable desktop updater also reports
latestVersion: 1.14.4.minAppVersionstays at 1.13.0. The newer declarations require three secret-selection parameters to acceptstring | null; the existing clear-selection branch already handles null. Those type edits erase from JavaScript. No settings, storage, public API, URI, or migration changes.Note
Resolve dev dependency alerts and fix null credential selection in settings
eslint-plugin-obsidianmd, and oxfmt for vite-plus pinned to the manifest's version, in package.json and package-lock.jsonhandleSecretSelection,saveSecretReference, andpersistSecretReferencenow accept a null selection and persist an empty credential reference instead of requiring an identifierMacroscope summarized be5d902.