Repository navigation
chore(e2e): adopt the native obsidian-e2e Linux runner - #395
Merged
Merged
Conversation
Deploying podnotes with
|
| Latest commit: |
1408a63
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f74365a6.podnotes.pages.dev |
| Branch Preview URL: | https://chore-obsidian-e2e-0-13.podnotes.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
obsidian-e2e0.13.0's native Linux runner for startup and journey restarts. This removes both local launch implementations and fixes the leftover Xvfb temp directory reproduced on the baseline.The existing npm commands retain test ownership cleanup, the restart profile guard, startup error recording, and player capture presets. The dependency lockfile changes only the requested package entries.
Verification
origin/masteratf7400bawith a merge commit. The single conflict was therestartObsidianJSDoc. Both explanations survive. The merged function retains fix(persistence): merge data.json with changes made on other devices instead of overwriting them #388'sbeforeCloserenderer hook and the upstream launcher and readiness wait. Resolution and run summary.1408a63b6dd62ef05e5a5f00ea18655b8d42c8f0, Node 22.23.2 and npm 10.9.8 passednpm ci && npm run build. Two sequentialnpm run test:e2eruns each passed all 53 tests in 11 files against Linux Obsidian 1.13.7 and a fresh isolated vault.npm run lint,npm run format:check,npm run typecheck,npm run build,npm run test -- --maxWorkers=2andnpm run docs:buildpassed. Unit tests passed 1,386 tests in 86 files with zero Svelte errors or warnings. Docs built 15 pages and validated 73 legacy fragments.npm run sizepassed at 314,794 raw bytes and 99,368 gzip bytes at level 9.xvfb-run.*directories inTMPDIR=/data/home/tmp/podnotes-OE-ADOPT. The final stop dry-run reportspids: none. Merged-head logs and repeatable cleanup driver.Fixture:
http://127.0.0.1.nip.io:35476/feed.xml; local audio:Fixtures/Local Fixture.wav(60 seconds). No runtime errors captured. Exact commands and limits, logs and repeatable drivers, screen recording, Settings screenshot.Compatibility
Linux
start --print-envnow returns upstream's exports withoutXDG_RUNTIME_DIR; usenpm run obsidian:e2e -- <command>for CLI calls. Runtime docs reflect this and the new log location. The runner migration adds no plugin source, settings, storage, API or URI contract changes. The master merge inherits #388's persistence changes.macOS journey restart now uses upstream's launcher and needs a macOS smoke check of J-PLAY-11 and J-EDGE-03. Failure cleanup after launch was verified by code tracing, without runtime failure injection. The observed local-file artwork defect is tracked separately in #394.
Note
Replace local Linux E2E runner shim with native obsidian-e2e 0.13 support
obsidian-e2efrom^0.12.1to^0.13.0in package.json and deletes the local Linux compatibility layer in scripts/obsidian-e2e.mjs (custom launcher, version sources, warm-instance guard, XDG cleanup).launchObsidianInstancepluswaitForInstanceReadyinstead of the local relaunch helper.xvfb-runonly whenDISPLAYis unset; usenpm run obsidian:e2eon Linux since the raw CLI does not work there.obsidian.log) are now owned by the upstream runner; Linux environment setup no longer exportsXDG_RUNTIME_DIR.Macroscope summarized 1408a63.