Skip to content

"Remove file" on a local file sends the user's original audio to the trash #354

Closed

Description

@chhoumann

Problem. "Play with PodNotes" on a vault audio file registers the original file as a downloaded episode (src/getContextMenuHandler.ts:61-65). The episode context menu then offers "Remove file", which calls fileManager.trashFile on that path (src/ui/PodcastView/spawnEpisodeContextMenu.ts:87-96, src/downloadEpisode.ts:360-376). The user's own recording goes to the trash.

Repro (hypothesis). Right-click a.mp3 in the file explorer, choose Play with PodNotes, open the Local Files tile, right-click the episode, choose Remove file.

Acceptance. Reproduced in real Obsidian first. After the fix, PodNotes never deletes a file it did not download itself, and an end-to-end test covers it.

Found by the PodNotes codebase audit. Not yet reproduced in Obsidian.

Activity

  1. added a commit that references this issue on Oct 11, 2026
    7476423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions