Repository navigation
Do not try all runners in runner discovery #2834
Description
In the runner discover function (DiscoverRunner), the logic loops through all registered runners, and even if many are found (which is likely impossible), it only takes the first one.
When executing with the --debug option, you can see how some of those runners are trying to open system files (to discover k8s configuration for Tekton, for example), or doing some API calls (Github for example). This is a waste of resources and makes the attestation init step slower as we add more runner implementations.
Instead, the for loop should stop after the first one is found, and return it directly.
Activity
waveywaves commentedon Mar 11, 2026
can you assign this to me considering it's related to Tekton ?
javirln commentedon Mar 12, 2026
Has this been here forever?
jiparis commentedon Mar 12, 2026
It's been there since the beginning, yes.
jiparis commentedon Mar 12, 2026
@waveywaves not strictly related, but sure, all yours!
fix: return early in DiscoverRunner to avoid unnecessary env checks
fix: return early in DiscoverRunner on first match