Skip to content

fix: Add network timeout ctx to Espresso client - #534

Open
Sneh1999 wants to merge 2 commits into
espresso/batcherfrom
add-network-timeout-espresso-client
Open

fix: Add network timeout ctx to Espresso client#534
Sneh1999 wants to merge 2 commits into
espresso/batcherfrom
add-network-timeout-espresso-client

Conversation

@Sneh1999

@Sneh1999 Sneh1999 commented Sep 24, 2026 •
edited by philippecamacho
Loading

Copy link
Copy Markdown
Collaborator

Description

  • Add a network timeout to every Espresso SDK operation.
  • Add a timeout to streamer L1/L2 RPC calls.
  • Clear the stopped Espresso streamer so restarts do not re-anchor against stale state.

philippecamacho
philippecamacho reviewed Sep 29, 2026
View reviewed changes
Comment thread op-batcher/batcher/espresso.go Outdated
philippecamacho
philippecamacho reviewed Sep 29, 2026
View reviewed changes
Comment thread op-batcher/batcher/espresso_driver.go
philippecamacho
philippecamacho reviewed Sep 29, 2026
View reviewed changes
Comment thread op-batcher/batcher/driver.go
This was referenced Sep 29, 2026
Open
Closed
philippecamacho
philippecamacho approved these changes Sep 29, 2026
View reviewed changes

@philippecamacho philippecamacho left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions. LGTM. (PLEASE DO NOT MERGE before cLabs approval.)

jjeangal
jjeangal approved these changes Sep 29, 2026
View reviewed changes

@jjeangal jjeangal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. I do not have much to say that hasn't been said.

Comment thread op-batcher/batcher/espresso.go Outdated
@philippecamacho philippecamacho mentioned this pull request Sep 30, 2026
Open
@philippecamacho
philippecamacho marked this pull request as ready for review September 30, 2026 14:07
@philippecamacho philippecamacho mentioned this pull request Sep 30, 2026
Open
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T16:05:15.899392Z 3b4acaa New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philippecamacho philippecamacho philippecamacho approved these changes
@jjeangal jjeangal jjeangal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sneh1999 @philippecamacho @jjeangal