Repository navigation
fix: ci: catch all .devcontainer changes with wildcard - #35
Merged
Merged
Conversation
added 3 commits
September 25, 2026 08:26
TERM was hardcoded to xterm-256color in .bashrc, overriding tmux.conf's TERM=tmux-256color. This breaks color rendering in tmux-based editors (nvim) and terminal applications. Terminal/tmux correctly sets TERM themselves based on $TERM or session type. Removing the export lets them manage this properly. Fixes color/display issues when using the devcontainer within tmux. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Entire-Checkpoint: 93fa1151a4ff
apt-fzf and apt-fzf-purge bash functions use sudo, but sudo is not installed in the container and dev user has no root permissions. These functions are not core devcontainer features and containers use different package management approaches anyway. Removing them prevents "command not found" errors and simplifies the bash config. Fixes issue #22. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Entire-Checkpoint: 044f41449fec
CI filter previously listed individual files: Dockerfile, devcontainer.json. But Dockerfile copies additional files (tmux.conf, onboard.sh, hooks/), so changes to those missed the build trigger → stale :latest tag. Replace with .devcontainer/** to catch all file changes in that directory. Reduces maintenance burden and ensures builds trigger correctly. Fixes issue #20. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Entire-Checkpoint: e86a09f0184c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI filter lists individual files in
.devcontainer/:But Dockerfile copies additional files (tmux.conf, onboard.sh, hooks/) that aren't in the filter. Changes to those files don't trigger rebuilds → stale :latest tag.
Solution
Replace individual paths with
.devcontainer/**wildcard. This catches all file changes in the directory.Impact
Example
Before: changing tmux.conf → no rebuild
After: changing tmux.conf → build triggered ✓
Closes #20.
🤖 Generated with Claude Code