Ap identification - #1854
Ap identification#1854SFJohnson24 wants to merge 14 commits into
Conversation
pendingintent
left a comment
There was a problem hiding this comment.
AP-- will not have an associated domain other than APRELSUB. MH will not have a relationship to APMH. All AP domains are only to record details for a person associated with a USUBJID. There is no parent/child relationship with AP--. The suffix only indicates the type of data collected in the dataset. In this case, this is medical history for the associated person. The APID in APMH will join to APRELSUB.APID and the APRELSUB.USUBJID will indicate to which subject the person is associated.
|
I removed the logic for AP that I preserved, that was built on a false premise. I updated tests as the ap_suffix had several failing tests where there was no metadata on the dataset--meaning a dataset was submitted but completely empty. It no longer returns "" and instead would error out given the total lack of metadata. I would expect this given the blank data which would force a rule skip for that dataset and rule |
|
AP-Domains.xlsx |
pendingintent
left a comment
There was a problem hiding this comment.
AP-Domains-negative.xlsx
CORE-Report-2026-09-15T10-13-10.xlsx
I have executed the API-Applicable rules against the datasets in AP-Domains-negative.xlsx.
python core.py validate -s sdtmig -v 3-4 -r CORE-000181 -r CORE-000233 -r CORE-000234 -r CORE-000235 -r CORE-000778 -r CORE-000180 -r CORE-000510 -r CORE-000201 -r CORE-000376 -dp /Users/dmoreland/Downloads/AP-Domains.xlsxI am seeing one issue. CORE-000778 is showing a false positive - Associated Persons non-supplemental qualifier dataset associated with a split dataset does not have a dataset name with a length greater than 4 and less than, or equal to, 6. There is no split dataset included in the test data.
|
note: the test suite failure is expected given the changes in scope (rules involving split and supp are failing) |
This PR updates logic for identifying AP class which used to seek out the parent dataset then ID based on that. This PR still uses that logic, if it fails, it attempts to use the AP suffix--testing it in the case of both standard and custom domains attached to AP--.