Repository navigation
Feature/auth - #14
Merged
Merged
Feature/auth#14
Conversation
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
reviewed
Dec 1, 2020
jacky-htg
requested changes
Dec 1, 2020
jacky-htg
left a comment
jacky-htg
left a comment
Contributor
There was a problem hiding this comment.
POST /forgot-password
- need 1 input only : email
- add sql script for create forgot_passwords table
- add logic step by step
- add negative case for scenario not found in database. the email input is valid, but no record in the database.
jacky-htg
requested changes
Dec 1, 2020
jacky-htg
left a comment
jacky-htg
left a comment
Contributor
There was a problem hiding this comment.
many my feedback has been resolved. You need to resolve two point below:
- add sql script create forgot_password tables.
- add step by step logic
jacky-htg
requested changes
Dec 3, 2020
jacky-htg
left a comment
jacky-htg
left a comment
Contributor
There was a problem hiding this comment.
Please resolve my comments below. thanks.
jacky-htg
approved these changes
Dec 3, 2020
fakhri007
requested review from
a team,
dzakitajudin,
ferrystiawan,
jacky-htg,
juniarthaim and
lukman134
December 4, 2020 06:41
jacky-htg
reviewed
Dec 4, 2020
| --- | --- | ||
| Content-Type | application/json | ||
| Accept | application/json | ||
| Email | application/json |
Contributor
There was a problem hiding this comment.
The example value of Email is rijal.asep.nugroho@gmail.com, not application/json
msyuniarto
requested changes
Dec 5, 2020
) * [#3] Update Regions Documentation and add a figure of regions table * [#3] Update Region Documentation based on review * [#3] Update Region Documentation based on 2nd review * [#3] add region code must be unique and remove the last line that does not need comma * [#3] Update region-layer * [#3] Rename regions.png to region-layer.png * [#3] Remove company_code and kunci from regions table
msyuniarto
requested changes
Dec 7, 2020
msyuniarto
approved these changes
Dec 7, 2020
ferrystiawan
approved these changes
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.