You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Hardening: Improve current set of tests [unit]聽#475
Failure results in some of the tests from builder.test.ts.
馃珷 Actual behavior
All of them are passing. But it is due to how the component tested works and the assertions made. The only thing highlighting the problem is the IDE when you open the file.
馃И Minimal test case
Have an IDE that has a TS language server running,
Open the file on apps/cli/tests/unit/compose/builder.test.ts,
You should be able to see the red "squiggles". Types do not match.
鉁旓笍 Possible solutions
Fix the tests following the types
Add strict typing checking to bring build and ci to fail/halt
Overhaul the types in the src/types/compose.ts by removing properties that are not used or do not make sense anymore, e.g., Models.
@endersonmaia@tuler, as you guys are from the very beginning. What are those models for? Is that still something to be pursued, and if so, why? Or can we get rid of it?
So I need some help clarifying these, as I will start inspecting more closely and working on increasing tests/checks.
Activity
brunomenezes commentedon Apr 23, 2026
@endersonmaia @tuler, as you guys are from the very beginning. What are those
modelsfor? Is that still something to be pursued, and if so, why? Or can we get rid of it?So I need some help clarifying these, as I will start inspecting more closely and working on increasing tests/checks.
endersonmaia commentedon Apr 23, 2026
It's part of the compose-spec, we just converted it to TypeScript types.