fix(admin): update aria-expanded and label when mobile menu is toggled - #714
fix(admin): update aria-expanded and label when mobile menu is toggled#714Ferryx349 wants to merge 1 commit into
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR improves admin dashboard accessibility and keyboard handling by updating ARIA attributes on the mobile navigation toggle and refining which keypresses trigger global shortcuts.
Changes:
- Update
#menu-toggleto dynamically reflect drawer state viaaria-expandedand a statefularia-labelinsetNavOpen(). - Treat
<select>elements as “typing targets” to avoid triggering global shortcuts while interacting with form controls. - Ignore global shortcut handling when modifier keys (Meta/Ctrl/Alt) are pressed to prevent unintended actions (e.g., browser/system shortcuts).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
This PR updates
aria-expanded(true/false) and dynamicaria-label(Open navigation/Close navigation) on#menu-toggleinsidesetNavOpen()so screen readers receive real-time navigation drawer state changes.Related Issue
Closes:- #712.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: