Skip to content

Create google.yml - #37

Closed
snekiam wants to merge 3 commits into
devfrom
snekiam-gcloud-deploy
Closed

snekiam wants to merge 3 commits into
devfrom
snekiam-gcloud-deploy

Conversation

@snekiam

@snekiam snekiam commented Feb 2, 2020

Copy link
Copy Markdown
Member

This still needs some configured secrets to actually work.

This still needs some configured secrets to actually work.
@mfekadu

mfekadu commented Feb 3, 2020

Copy link
Copy Markdown
Member

So #36 is related to this right? Should we wait until #36 is merged or go ahead and merge this?

@snekiam

snekiam commented Feb 3, 2020

Copy link
Copy Markdown
Member Author

Yes, that's probably true - this won't explicitly not work without #36 - #36 just puts some placeholder files in and adds some stuff to the .gitignore to make sure keys don't get pushed accidentally.

This includes some config items for kubernetes on gcloud.
@snekiam

snekiam commented Feb 9, 2020

Copy link
Copy Markdown
Member Author

I've updated this PR with some more files required for google cloud deployes - @mfekadu can you take another look?

@mfekadu

mfekadu commented Feb 21, 2020

Copy link
Copy Markdown
Member

@snekiam I'm unable to verify the google.yml without

  1. merging into the dev branch (because GitHub runs the workflow on a push to dev) (also see the "P.S." below)
  2. including the secrets referenced inside google.yml
  GKE_PROJECT: ${{ secrets.GKE_PROJECT }}
  GKE_EMAIL: ${{ secrets.GKE_EMAIL }}

So let's add those secrets together on Sunday (or you can feel free to add the secrets here)

P.S. An alternative way to test the google.yml workflow is my creating a dummy repository on GitHub. If you have time, would you like to try that and include screenshots of how that went here?

@snekiam

snekiam commented Feb 21, 2020

Copy link
Copy Markdown
Member Author

Its probably best if I just create a dummy repo for testing - I haven't really been able to test this yet.

@snekiam snekiam closed this Feb 21, 2020
@mfekadu

mfekadu commented Feb 26, 2020

Copy link
Copy Markdown
Member

related #67

@snekiam
snekiam deleted the snekiam-gcloud-deploy branch March 1, 2020 22:37
@mfekadu mfekadu mentioned this pull request Mar 7, 2020
1 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants