Repository navigation
Updated workflow to use secret, cron now outputs reasonably - #191
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Jason-Ku
approved these changes
Aug 9, 2020
mfekadu
approved these changes
Aug 9, 2020
| @@ -1 +1 @@ | |||
| 0 15 * * * /nimbus/cert-update.sh | |||
| 0 15 * * * /nimbus/cert-update.sh > stdout | |||
| env: | ||
| GCE_PROJECT: ${{ secrets.GCE_PROJECT }} | ||
| GCE_INSTANCE: nimbus-api-test | ||
| GCE_INSTANCE: ${{ secrets.INSTANCE_NAME }} |
Member
There was a problem hiding this comment.
yes, as long as the secrets are set then it's good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's New?
Use the INSTANCE_NAME from secrets to deploy to gcp.
Updated the cron to update SSL certs to output to stdout, which is logged by docker
Fixes (works toward) #188
Type of change (pick-one)
How Has This Been Tested?
This doesn't change the way the api runs locally, it'll have to be tested on deploy.
Checklist (check-all-before-merge)
formatting help:
- [x]means "checked' and- [ ]means "unchecked"I documented my code according to the Google Python Style Guide
I ran
./build_docs.shand the docs look fineI ran
./type_check.shand got no errorsI ran
./format.shbecause it automatically cleans my code for me 😄I ran
./lint.shto check for what "format" missedI added my tests to the
/testsdirectoryI ran
./run_tests.shand all the tests pass