[ryanjwessel]

Summary

Users migrating from @testing-library/react-native will have to update their accessibility queries due to a slightly different naming convention. This PR adds aliases for the @testing-library/react-native queries to be usable in this library.

This is motivated by the thread on Issue #442

Test plan

I am not sure about testing this. I can make additions to this PR if needed. The test suite passes, and I see a11yAPI.test.js uses only the a11y version of the queries.

To Note

The queries for placeholder text are not one-to-one between the two libraries, but I don't think those are set up for aliasing yet. All of the @testing-library/react-native placeholder queries are appended with Text, whereas this library does not do that.

[thymikee]

Great start! Now we need a simple test (copy what we have already) and update typings alongside with their tests (for TypeScript, check typings directory)

[ryanjwessel]

Thanks @thymikee! I duplicated the tests and updated the types. I'm not quite sure what typings/__tests__/index.test.tsx is doing, but I updated that as well. I can revert that change if needed.

[mdjastrzebski]

Overall LGTM.

nit: No sure if I would actually duplicate the unit tests for function aliases though. People reading code might be confused whether these are aliases or actual functions. Please put the expects from new query aliases next to expects from original A11y queries in the respective test suits.

Duplicated typescript typing "tests" are fine. As this is different.

[ryanjwessel]

Fair point @mdjastrzebski. I think they should fall under the same test blocks since they are covering the same functionality. I'll update this now.

[ryanjwessel]

I have consolidated the tests, but there were some issues with this. I added some FIXME tags where the tests were failing due to the consolidation. Two out of three seem to have trouble with async during ...AllBy queries. I haven't had time to dig into why though.

Also, I updated the docs to include these new queries.

[mdjastrzebski]

Spotted few aliases to rename.

[ryanjwessel]

Thanks for your review @thymikee and @mdjastrzebski! I just pushed an updated a11yAPI test file that asserts referential equality for the query aliases. The test suite is passing, and the diff is a lot simpler now. 😄

Please let me know if there are any other changes either of you feel are necessary.

[thymikee]

Looks good, left one more note to consider 👍

[thymikee]

Thank you very much for you contribution @ryanjwessel, appreciated!

[ryanjwessel]

Thank you both for your help! This was my first ever contribution to OSS, so I am really grateful for your guidance in contributing to this project. Glad I was able to contribute!