Repository navigation
refactor(superdeck): vendor the syntax highlighter; drop CocoaPods - #126
Merged
leoafarias merged 3 commits intoSep 23, 2026
Merged
Conversation
Characterizes highlighting for Dart, JSON, YAML, Markdown, Python, and the Dart fallback on light and dark backgrounds, so a change of highlighter implementation must reproduce the output exactly.
syntax_highlight depends on super_clipboard for a CodeEditor widget SuperDeck never uses, which pulls super_native_extensions and irondash_engine_context into every SuperDeck app: native plugins with no Swift Package Manager support and a known Android 16 KB page-size crash. Upstream fixes (serverpod/syntax_highlight #20, #22) have been unreviewed since April and July 2026. Vendor only the highlighter and its span parser, with their grammars and themes, under an attribution header and licence. Rendered output is unchanged: the recorded-spans test passes against the vendored copy.
Every plugin for macOS and iOS now resolves through Swift Package Manager, so de-integrate CocoaPods from the demo and playground macOS apps and the demo iOS app: drop the Podfiles, their locks, the Pods xcconfig includes, and the workspace references, as Flutter's migration guide describes. The iOS project also takes Flutter's pending migrations (UIScene lifecycle, implicit-engine plugin registration, Swift Package Manager integration) and a 15.0 deployment target, the lowest Xcode 27 supports.
4 tasks
|
Visit the preview URL for this PR (updated for commit 86ced33): https://superdeck-dev--pr126-refactor-vendor-synt-3inwiqj7.web.app (expires Fri, 23 Oct 2026 03:33:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bd68fc230762285849207e7e120aaf87cd4ca2f9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Stack 2/8, based on #125. It removes the last native dependencies that force CocoaPods, then removes CocoaPods from every Apple app.
Why:
syntax_highlightdepends onsuper_clipboardonly for itsCodeEditorwidget, which SuperDeck never uses. That dependency pullssuper_native_extensionsandirondash_engine_contextinto every SuperDeck app:super_native_extensions0.9.1 crashes on Android devices with 16 KB memory pages.syntax_highlight0.5.0 capssuper_clipboardbelow them.super_clipboard(serverpod/syntax_highlight feat: add Claude Code configuration #20, feat(core): add Deck.schema for complete presentation validation #22) have gone unreviewed since April and July 2026.Commits
test(superdeck): record the highlighter's exact rendered spans (text, color, weight, style) for Dart, JSON, YAML, Markdown, Python and the Dart fallback, on light and dark backgrounds.refactor(superdeck): vendor onlyhighlighter.dartandspan_parser.dart(BSD-3; the parser originally comes from Flutter DevTools), plus the grammars and themes, underlib/src/markdown/syntax_highlight/vendor/. It follows thevendor/convention: attribution header,LICENSE, and the two local changes markedSUPERDECK PATCH(the import path and the asset paths).string_scanner.pubspec.lockdropssyntax_highlight,super_clipboard,super_native_extensionsand bothirondashpackages.build(apple): with every plugin now on SPM, remove CocoaPods from the demo and playground macOS apps and the demo iOS app, following Flutter's migration guide (pod deintegrate, delete the Podfiles and locks, remove the Pods xcconfig includes and workspace references). The iOS project also takes Flutter's pending migrations and a 15.0 deployment target, the lowest Xcode 27 supports.Impacted packages
superdeck(a dependency change for downstream apps, noted in CHANGELOG), and thedemoandplaygroundplatform projects.Commands run
fvm flutter testinpackages/superdeck: 776 passing, including theci-excludedgoldens with no updates. The recorded-spans test passes against the vendored copy, so there's no visual change.fvm dart analyze --fatal-infosin all 7 packages: no issues.fvm flutter build macos --debugfor demo and playground after a clean: both build with no CocoaPods.fvm dart run melos run test:integration:macos --no-select: 39 passing.fvm flutter build ios --debug --no-codesignfor the demo: builds.Known toolchain issue (not caused by this PR)
flutter build ios --simulatorfails with Flutter 3.44.6 on Xcode 27. Flutter callslipo -verify_arch arm64 x86_64, but Xcode 27'slipoaccepts one architecture per call ("-verify_arch requires exactly one input file"). Device builds and single-architecture simulator runs are unaffected.