Repository navigation
Windows project directory can hijack relative Flutter and Dart proxy executables - #1091
Draft
leoafarias wants to merge 1 commit into
Draft
leoafarias wants to merge 1 commit into
leoafarias wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configured Flutter and Dart launches now bypass project-directory command search.
VersionRunnerconverts selected SDK Flutter and Dart paths to absolute executables before process launch.flutterordartfiles on this path.fvm execcommands retain shell and PATH resolution, with regression assertions covering both branches.Static Verification Checks
Configured proxy binding (Passed) — FlutterCommand, DartCommand, and RunConfiguredFlutterWorkflow reach VersionRunner.run, which selects absolute SDK executables and disables shell lookup.
Collision regression assertions (Passed) — test/services/flutter_service_test.dart asserts project collisions cannot replace configured Flutter or Dart executables at the process boundary.
Custom execution compatibility (Passed) — VersionRunner.run preserves arguments, SDK PATH entries, and shell lookup for arbitrary fvm exec commands.
Static verification scope (Passed) — git diff and VersionRunner.run received source-only inspection; runtime checks were not performed, defining static verification scope.
Finding:
acf_3b4acd341b39a23246d4ce9c8f94d799Patch:
arp_c68195d5d61239bc2409eab07500d843Base commit:
d3cdc1f8588047aac262aecdfea1182a3fe44ccaPatch SHA-256:
082db5c59c04af5293056c1e7d8cecee52d9c4ec4f754ac47975a4207ec821a0