Repository navigation
fix: tighten CLI error reporting for setup, typos, and VS Code opt-out - #1077
Draft
leoafarias wants to merge 2 commits into
Draft
leoafarias wants to merge 2 commits into
leoafarias wants to merge 2 commits into
Conversation
- Fail `fvm install`/`fvm use` when Flutter SDK setup exits non-zero instead of reporting "is setup" after an error (#968) - Report unknown commands such as `fvm fluter --version` as usage errors instead of printing the FVM version (#761) - Stop warning when `updateVscodeSettings: false` is set; the opt-out is intentional configuration (#1048) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011SmK6LGRTwTTAD1GQuMw4q
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The retry hint named `fvm install <name>`, which drops the fork prefix and is wrong when setup runs from `fvm use`. Also drop a runner test that duplicated the existing --version coverage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011SmK6LGRTwTTAD1GQuMw4q
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three small, confirmed bugs where FVM's output misreports what happened.
SetupFlutterWorkflowignored the exit code offlutter --version. For example, whenunzipwas missing, FVM printed✓ ... is setupright after the error. It now throws anAppException("Flutter SDK setup exited with code N. Fix the error above and try again.") on a non-zero exit, sofvm installandfvm usefail loudly.fvm fluter --versionnow reports an unknown command. The misspelled command landed inrest, while the trailing--versionwas parsed as the top-level flag, so FVM printed its own version. The version shortcut now applies only whenrestis empty, and the base runner reportsCould not find a command named "fluter"(exit 64).updateVscodeSettings: falseis set. This is an explicit opt-out, so the warning was just noise in local runs and CI. The message is now debug-only.Closes #968, closes #761, closes #1048
Behavior change
fvm install/fvm usenow exit non-zero when SDK setup fails. Before, they continued and later printedFlutter SDK is not setup, skipping resolve dependencies. Scripts that relied on the old exit 0 after a broken setup will now fail.--skip-setup/--no-setupstill bypass setup.Validation
test/src/runner_test.dart, plus new cases insetup_flutter.workflow_test.dartandupdate_vscode_settings.workflow_test.dart. All three fail onmainand pass with this change.dart analyze --fatal-infos: no issues. CI (includingdcm, integration, and migration jobs) was green on the first commit.dart test -x 'sdk || network || git || integration || migration': 455 passed, 3 failed. The 3 failures are the existing file-permission tests, which also fail on unmodifiedmainin the sandbox because it runs as root.fvm install <version.name>, which drops the fork prefix and is wrong when setup runs fromfvm use. It now just says to fix the error and try again. I also removed a--versiontest that duplicatedcommands_test.dart.Notes