Skip to content

fix: wait for Flutter cleanup after SIGINT - #1054

Merged
leoafarias merged 6 commits into
btwld:mainfrom
zHElEARN:fix/flutter-interrupt-cleanup
Sep 4, 2026
Merged

leoafarias merged 6 commits into
btwld:mainfrom
zHElEARN:fix/flutter-interrupt-cleanup

Conversation

@zHElEARN

Copy link
Copy Markdown
Contributor

Summary

  • Keep FVM alive until the proxied Flutter process finishes its SIGINT cleanup.
  • Exit with code 130 and stop workflows from continuing after interruption.
  • Add a POSIX PTY regression test for terminal and process cleanup.

This prevents fish from being left in an unusable terminal state after pressing Ctrl+C during a Flutter command.

Fixes #1046

Testing

  • dart analyze --fatal-infos
  • Unit and PTY tests
  • Manual verification with fvm flutter doctor -v in fish

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

@zHElEARN is attempting to deploy a commit to the FlutterTools Team on Vercel.

A member of the Team first needs to authorize it.

@leoafarias leoafarias left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against current main after the DCM cleanup. The PTY regression proves FVM waits for child cleanup, restores the terminal, removes the process group, and exits 130. Analyzer, DCM, 455 fast tests, the isolated manual branch smoke test, and the complete nine-job GitHub matrix pass.

@leoafarias
leoafarias merged commit bf5927a into btwld:main Sep 4, 2026
10 of 11 checks passed
@zHElEARN
zHElEARN deleted the fix/flutter-interrupt-cleanup branch September 15, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] FVM leaves fish terminal wedged in raw mode after Ctrl+C mid-command

2 participants