Skip to content

Add Ack 2.0 agent skills for Cursor, Claude Code, and Codex - #264

Open
leoafarias wants to merge 2 commits into
mainfrom
ack-agent-skills-plugin
Open

leoafarias wants to merge 2 commits into
mainfrom
ack-agent-skills-plugin

Conversation

@leoafarias

@leoafarias leoafarias commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add the using-ack, build-data-classes-with-ack, and ack-provider-schemas skills and their focused references. Register the same plugins/ack bundle in the Cursor, Claude Code, and Codex marketplaces.

The skill reruns clarified class-first versus schema-first exports, added a concrete date-bound schema-first example, and made explicit that “latest” is not consent to move from stable to a major prerelease. Provider examples now include a self-contained nested-error helper and explain the local-midnight result of Ack.date(). All three cards point to the version-matched repository index rather than depending on the state of the hosted copy.

This PR intentionally excludes the fixture harness, website patch, bug handoff, and optional deploy-hook workflow. The website refreshes on its own builds via btwld/website#60. The two library edge cases are tracked separately in #262 and #263.

Fixture Results

All nine fixtures passed. Ran the plugin in isolated Claude Code sessions with Dart 3.14.0 and Flutter 3.50.0, against this repository's actual 2.0.0-beta.3 packages via path overrides. All Dart code fixtures finish with dart analyze reporting No issues found!; the Firebase fixture also passes flutter analyze and flutter test. Provider responses are mocked.

# Fixture Green result and red control
1 Class-first Invoice Generated round trip, presence/defaults, validated encode and load; removing the date-order refinement fails the rejection test.
2 Schema-first Payment Generated union, UTC decode, Draft-7 export and nested warning; removing the date bound fails the 2025 rejection.
3 2020-12 bundle Relative $ref, Unicode pattern, validated Message, preserved export; disabling builder format assertions fails the bad-timestamp test.
4 MCP tools In-memory defaults, error paths and output schema; removing the whitespace refinement accepts an invalid query and fails the test.
5 Firebase AI Mocked response schema and weather-report gate; removing the low/high refinement fails two rejection assertions.
6 1.7 migration Asks before changing the pin, migrates after “yes,” and verifies copyWith(null) clears the field; removing the length annotation fails the invalid-name test.
7 Webhook schema No codegen, strict keys, typed presence and nested error paths; removing optionality fails the omitted-tags check.
8 Non-Ack prompts json_serializable, Zod, and Flutter form prompts load no Ack skill and add no Ack dependency. A known Ack Skill event makes the transcript guard fail.
9 Gemini REST tool Mocked request export and typed dispatch; removing the title minLength lets the invalid call reach the tool and fails the test.

Open workspace in Conductor

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T22:05:00.217986Z 1ae8197 New commits
🔒 Security Review ✅ Completed 2026-11-20T22:05:53.032484Z 1ae8197 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95ae2635ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Iterable<AckSchemaModelWarning> allWarnings(AckSchemaModel model) sync* {
yield* model.warnings;
final children = switch (model) {
AckObjectSchemaModel(:final properties) => properties?.values ?? const [],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Traverse map value schemas when collecting export warnings

For a schema such as Ack.map(Ack.datetime().min(DateTime.utc(2026))), this helper returns no warnings even though the date bound is dropped during export. AckSchemaModelBuilder._map stores the value model in AckAdditionalPropertiesSchema.schema, not in properties, so this branch skips it entirely. Because the other skills explicitly rely on this helper to inspect every export warning, map-valued fields can silently bypass that check. Include schema-valued additionalProperties among the children visited.

Useful? React with 👍 / 👎.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant