Repository navigation
Add Ack 2.0 agent skills for Cursor, Claude Code, and Codex - #264
leoafarias wants to merge 2 commits into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95ae2635ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Iterable<AckSchemaModelWarning> allWarnings(AckSchemaModel model) sync* { | ||
| yield* model.warnings; | ||
| final children = switch (model) { | ||
| AckObjectSchemaModel(:final properties) => properties?.values ?? const [], |
There was a problem hiding this comment.
Traverse map value schemas when collecting export warnings
For a schema such as Ack.map(Ack.datetime().min(DateTime.utc(2026))), this helper returns no warnings even though the date bound is dropped during export. AckSchemaModelBuilder._map stores the value model in AckAdditionalPropertiesSchema.schema, not in properties, so this branch skips it entirely. Because the other skills explicitly rely on this helper to inspect every export warning, map-valued fields can silently bypass that check. Include schema-valued additionalProperties among the children visited.
Useful? React with 👍 / 👎.
Summary
Add the
using-ack,build-data-classes-with-ack, andack-provider-schemasskills and their focused references. Register the sameplugins/ackbundle in the Cursor, Claude Code, and Codex marketplaces.The skill reruns clarified class-first versus schema-first exports, added a concrete date-bound schema-first example, and made explicit that “latest” is not consent to move from stable to a major prerelease. Provider examples now include a self-contained nested-error helper and explain the local-midnight result of
Ack.date(). All three cards point to the version-matched repository index rather than depending on the state of the hosted copy.This PR intentionally excludes the fixture harness, website patch, bug handoff, and optional deploy-hook workflow. The website refreshes on its own builds via btwld/website#60. The two library edge cases are tracked separately in #262 and #263.
Fixture Results
All nine fixtures passed. Ran the plugin in isolated Claude Code sessions with Dart 3.14.0 and Flutter 3.50.0, against this repository's actual 2.0.0-beta.3 packages via path overrides. All Dart code fixtures finish with
dart analyzereportingNo issues found!; the Firebase fixture also passesflutter analyzeandflutter test. Provider responses are mocked.$ref, Unicode pattern, validatedMessage, preserved export; disabling builder format assertions fails the bad-timestamp test.copyWith(null)clears the field; removing the length annotation fails the invalid-name test.json_serializable, Zod, and Flutter form prompts load no Ack skill and add no Ack dependency. A known Ack Skill event makes the transcript guard fail.minLengthlets the invalid call reach the tool and fails the test.Open workspace in Conductor