doesn't support `$HOME/.node_modules` or `$HOME/.node_libraries`

[mk-pmb]

Hi, thanks for this module!
It seems to have trouble finding my packages, though:

$ readlink -m ~/.node_modules
/mnt/…/nodejs/modules
$ nodejs -e 'console.log(require.resolve("lodash")); require("resolve")("lodash", console.log);'
/mnt/…/nodejs/modules/lodash/lodash.js
{ Error: Cannot find module 'lodash' from '.'
    at /mnt/…/nodejs/modules/resolve/lib/async.js:50:31
    at processDirs (/mnt/…/nodejs/modules/resolve/lib/async.js:184:39)
    at ondir (/mnt/…/nodejs/modules/resolve/lib/async.js:199:13)
    at load (/mnt/…/nodejs/modules/resolve/lib/async.js:82:43)
    at onex (/mnt/…/nodejs/modules/resolve/lib/async.js:107:17)
    at /mnt/…/nodejs/modules/resolve/lib/async.js:12:69
    at FSReqWrap.oncomplete (fs.js:152:21) code: 'MODULE_NOT_FOUND' }

So require.resolve was able to find it, but resolve wasn't. However, it works when I create a symlink /mnt/…/nodejs/node_modules to modules.

Update: Work-around: It also works when I pass option { paths: [process.env.HOME + "/.node_modules"] }
Update 2: However, in that case I have to then explicitly resolve the returned path in order to get the exact same result.

[ljharb]

I think you'll need to set the preserveSymlinks option to true.

[mk-pmb]

Nope, doesn't seem to help:

$ nodejs -e 'console.log(require.resolve("lodash")); require("resolve")("lodash", { preserveSymlinks: true }, console.log);' 
/mnt/…/nodejs/modules/lodash/lodash.js
{ Error: Cannot find module 'lodash' from '.'
[…]

[mk-pmb]

To clarify, with "explicitly resolve the returned path" I meant I have to fs.realpath() it myself.

[ljharb]

(Possibly related to #122)

[safizn]

preserveSymlinks doesn't seem to work on Windows Symbolic link or Junction. Is there a problem with the implementation in the module ?
It never resolves to the real path, which what I needed from this module anyway. But the options preserveSymlinks: false, should work.
There seems to be a bug.

[ljharb]

@myuseringithub does node itself work with windows symlinks?

[mk-pmb]

I reproduced the problem and took an strace capture. The diff shows what really happened vs. what I'd expect to happen:

-stat64("/mnt/…/nodejs/modules/node_modules/lodash/package.json", …
+stat64("/mnt/…/nodejs/modules/lodash/package.json", …
 stat64("/mnt/…/nodejs/node_modules/lodash/package.json", …
 stat64("/mnt/…/node_modules/lodash/package.json", …
 stat64("/mnt/node_modules/lodash/package.json", …
 stat64("/node_modules/lodash/package.json", …

It seems resolve searches for modules in module directories inside of module search path directories, but not inside the module search path directories themselves.

[safizn]

@ljharb Yes, I use symbolic link of type Junction, as it allows me to create symlinks that are supported between the host machine (Windows OS), and the Docker container (Linux OS) which I'm running the app on. In my setup both the host machine and container use JS scripts to run the project.
Node's require.resolve('<a symlink>') returns the real path of the symlink as Node's command option --reserve-symlink is set to false by default.

[ljharb]

I'm unclear on what needs to be done here. Could anyone provide a repro repo, or better, a failing test case?

[mk-pmb]

Bug demo in GitLab Actions: https://github.com/mk-pmb/browserify-resolve-symlink-163

[ljharb]

@mk-pmb thanks - is there any way to repro it on the command line? When i run npm test I get:

> browserify-resolve-symlink-163@0.0.1 test
> bash demo.sh

readlink: illegal option -- m
usage: readlink [-n] [file ...]
demo.sh: line 11: cd: /prepare: No such file or directory

[ljharb]

@mk-pmb ah! resolve 1 has preserveSymlinks: true set by default. resolve 2 has preserveSymlinks: false set by default.

Try setting preserveSymlinks: false explicitly (or try a resolve 2 prerelease).

[mk-pmb]

is there any way to repro it on the command line?

Yes, if you run demo.sh in an environment similar enough to the GitHub Actions env.

readlink: illegal option -- m

You'll need GNU coreutils 8.21 or later installed. Ubuntu ships it by default, so I use that in the GitHub Actions.

Try setting preserveSymlinks: false explicitly (or try a resolve 2 prerelease).

Done in the no-preserve-symlinks branch, results are in.

[ljharb]

pify?
41    node.js resolver: /…/browserify-resolve-symlink-163/mnt/projects/webdev/js/modules/pify/index.js
42    "resolve" module: /…/browserify-resolve-symlink-163/mnt/projects/webdev/js/modules/pify/index.js

Seems like it's good! Does that mean this can be closed?

[mk-pmb]

The first two tests are the part that had been easy to fix ever since. The bug in my opening post is reproduced in the 3rd test case, and it still fails:

global-module-163?
    node.js resolver: /…/browserify-resolve-symlink-163/mnt/projects/webdev/js/secret_modules/global-module-163/dummy.js
    "resolve" module: Error: Cannot find module 'global-module-163' from '/home/runner/work/browserify-resolve-symlink-163/browserify-resolve-symlink-163/home/demo/my-cool-app'