New Command: "launch" - #466
Conversation
|
Neat, so vm mode runs a script, container mode runs a container, and compose runs your compose. Do we require the node to be connected/registered first so secure links work? Do we have any intention of supporting cleanup/teardown? |
My thought here was that we could support two levels of connectivity back to Brev:
The only "teardown" that exists is the fact that we use a temporary directory for git / mounting, and by default you are in the docker or vm script process, so hitting ctrl^c will kill the process. You can run the launch with |
| } | ||
| } | ||
|
|
||
| func detectBuildMode(info *store.LaunchableResponse) (localBuildMode, error) { |
There was a problem hiding this comment.
could we port this over to the remote launch also, we don't apply verb stuff there either. We should either reject or uptake Verb there (applyLaunchableBuildRequest)
| } | ||
|
|
||
| // If the launchable has a repository, clone it into the workspace | ||
| directory := filepath.Join(workspace, args.repository.Path) |
There was a problem hiding this comment.
for notebooks this will just be "url": "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/brevdev/notebooks/raw/main/oobabooga.ipynb". I think you might have to do some parsing like https://github.com/brevdev/dev-plane/blob/main/internal/remotefile/client.go does
Introduces a dedicated
launchcommand that launches launchables, both remotely and locally. Remote execution essentially copies the existingbrev create -l <id>flow (including some existing flags). Local execution:Demo:
brev.launch.mov
Helptext: