Repository navigation
fix(release): preserve runtime contracts and verify optimized artifacts - #1106
Merged
Merged
Conversation
ashwkun
added
the
user-impact-critical
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (25)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe PR enables narrower release optimization, adds checks for class, DEX, and resource contracts in optimized APK/AAB artifacts, and integrates those checks into pull-request and publication workflows. It also updates merge guidance for a maintainer-authorized required-check bypass. ChangesOptimized release contracts
Required-check bypass guidance
Priority: ⬆️ High Estimated code review effort: 4 (Complex) | ~60 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant ReleaseContractsWorkflow
participant GradleReleaseBuild
participant verify_release_contracts.py
participant APK_AAB
participant DiagnosticsArtifact
ReleaseContractsWorkflow->>GradleReleaseBuild: build optimized APK and AAB
GradleReleaseBuild->>APK_AAB: produce release artifacts
ReleaseContractsWorkflow->>verify_release_contracts.py: verify artifacts and write report
verify_release_contracts.py->>APK_AAB: inspect packaged contracts
verify_release_contracts.py->>ReleaseContractsWorkflow: return validation result
ReleaseContractsWorkflow->>DiagnosticsArtifact: upload report and mapping diagnostics
Merge Risk: ⚪ Minimal · up to No confirmed issue currently prevents merging after the usual release checks. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 4.62% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 65 functions across 8 files. (16 skipped: … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (8 passed)
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check |  |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Unresolved Review Threads | |
No unresolved review threads are present. The supplied review data reports no CodeRabbit review threads and zero actionable findings in the current review. |
| Architecture Compliance | |
No architecture violation is introduced. The PR changes no feature or core production source; the only main-source change is App Check provider selection in :app, where PostHog remains in the allowed … |
| Module Readme Updated | |
The PR changes one production Kotlin file under the covered paths: app/src/main/java/cx/aswin/boxlore/BoxLoreApplication.kt. The matching app/README.md is also modified in the same PR. No `core/<m… |
| Jvm Tests For Changed Logic | |
PASS: The PR does not add or substantially change an engine, repository, ViewModel, or pure helper under logic/. Its only Kotlin production change moves the existing App Check provider selection fro… |
| Title check | |
The title follows the required Conventional Commits format, uses the allowed type fix, uses the release scope, describes the release-contract changes, uses imperative wording, and is 71 characters… |
| Description check | |
The description clearly explains the release-build issue, the optimized-artifact validation changes, the compatibility constraints, and the test plan. It is directly related to the changeset. |
Full details: Docstring Coverage
Explanation
Docstring coverage is 4.62% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 65 functions across 8 files. (16 skipped: 16 unsupported.)
✨ Finishing Touches
📝 Generate docstrings
- Commit to this branch
- Create a new PR
- 🛠️ update changelog
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimized releases could post a new-episode alert but fail before WorkManager started its download or artwork-hydration job because an input-merger constructor was removed. Preserve runtime reflection contracts explicitly and check the actual optimized APK and app bundle before publication.
Motivation
Debug and JVM release tests use classes before R8 optimization, so they cannot detect missing runtime constructors, erased reflection metadata or removed resources in the shipped app.
What changed
Behavior & compatibility
Impact
user-impact-criticaluser-impact-highuser-impact-mediumuser-impact-lowno-user-impactbackend-changeListener impact
Fixes a release-build issue that could prevent automatic and Smart downloads from starting. The optimized app package is smaller while retaining its artwork, fonts and notification sounds.
Release copy
CHANGELOG.md
Fixed
Changed
Added
README What's New / Upcoming
Critical
Improvements
Test plan
Notes