Repository navigation
Secure webhooks, randomness and transaction logging - #18
Merged
Merged
Conversation
papac
commented
Oct 13, 2026
papac
commented
Member
- WebhookHandler: require a signature (an unsigned webhook was trusted and thus a forgeable "payment success") and verify it over the raw request body rather than a re-encoded array; comparison stays hash_equals.
- Common\Utils and MonoGateway: generate transaction references and UUIDs with a CSPRNG (random_int/random_bytes) instead of rand/mt_rand/uniqid.
- TransactionLogger: redact secret-bearing keys and create the log directory with 0700 permissions.
- WaveClient: URL-encode the session id in request paths.
- OrangeTokenGenerator: require HTTPS for the credential endpoint.
- WebhookHandler: require a signature (an unsigned webhook was trusted and thus a forgeable "payment success") and verify it over the raw request body rather than a re-encoded array; comparison stays hash_equals. - Common\Utils and MonoGateway: generate transaction references and UUIDs with a CSPRNG (random_int/random_bytes) instead of rand/mt_rand/uniqid. - TransactionLogger: redact secret-bearing keys and create the log directory with 0700 permissions. - WaveClient: URL-encode the session id in request paths. - OrangeTokenGenerator: require HTTPS for the credential endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.