Skip to content

Fix building on OpenBSD - #395

Merged
klemens-morgenstern merged 1 commit into
boostorg:developfrom
brad0:openbsd_build_fix
Oct 24, 2024
Merged

klemens-morgenstern merged 1 commit into
boostorg:developfrom
brad0:openbsd_build_fix

Conversation

@brad0

@brad0 brad0 commented Aug 24, 2024

Copy link
Copy Markdown
Contributor

OpenBSD does not have close_range() nor does NetBSD.

OpenBSD needs environ like the other *BSD's.

The build was erroring on kp_pid, it looks like p_pid is appropriate.

Fixes: #391

OpenBSD does not have close_range() nor does NetBSD.

OpenBSD needs environ like the other *BSD's.

The build was erroring on kp_pid, it looks like p_pid is appropriate.
@ghost

ghost commented Aug 25, 2024

Copy link
Copy Markdown

Hey, in case you were wanting to add other features to OpenBSD which are missing such as bp2::ext::exe you can base your code loosely on this file, just like I did with my past contributions to boost process v2:

https://github.com/time-killer-games/xproc/blob/main/process.cpp

Look for the function exe_from_proc_id().

Be sure to change the license from MIT to what boost process v2 has, I give you permission as the copyright holder of the relevent code. Process Hacker developers and devKathy are only responsible for small portions of code specific to the Windows platform, the rest I am the copyright holder for, which means I wrote all OpenBSD-related code, (and *BSD-related code as a whole). Make sure if you use enough of my code to be considered substantial that I am mentioned in the copyright of the related files (refer to me as "Samuel Venable").

I don't really have the time to add these features myself right now, but there is no obligation for you to do so either.

@ghost

ghost commented Sep 3, 2024

Copy link
Copy Markdown

Does this actually build now? If not, let me know once you solve all build errors. @klemens-morgenstern would like me to test this pull request once you are done.

@klemens-morgenstern
klemens-morgenstern merged commit 4d28e34 into boostorg:develop Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Process v2 does not build on OpenBSD

2 participants