Repository navigation
Release 0.1.2 - #271
Merged
Merged
Release 0.1.2#271
Conversation
One user-facing change (#270): a clone the host refuses as not-found now names the same repository under an owner devlaunch's completion cache knows, so a mistyped owner ends at "Did you mean 'kinisi-robotics/kinisi_ros'?" rather than at git's six lines of ssh advice. Divergence row 29. Also folds in the release-time half of `devlaunch-test-support`'s `versioned_with_the_workspace`, which asserts this crate's inherited version against a literal and so has to move with every release. It was left at "0.1.0" by the 0.1.1 bump, which no CI job caught — the `rust-parity` job tests devlaunch-runner, devlaunch-core, aid and dl by name and never this crate — so a developer's `cargo test --workspace` has been red since 0.1.1 and is green again here. The test is a tripwire for the crate tracking the workspace version; it cannot read that version any way other than the literal it compares.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRelease prep PR for devlaunch 0.1.2: bumps the workspace version, refreshes Cargo.lock, adds the 0.1.2 changelog section describing the single user-facing change, and fixes the devlaunch-test-support version tripwire test to match the new workspace version. Sequence diagram for dl clone not-found suggestion behaviorsequenceDiagram
actor User
participant dl
participant git
participant completion_cache
User->>dl: [runs dl kinisi/kinisi_ros]
dl->>git: [invoke git clone]
git-->>dl: [repository not found error]
dl->>completion_cache: [lookup owner/repository candidate]
alt [candidate found and cache does not know typed owner]
dl-->>User: [print git error text]
dl-->>User: [print Did you mean 'kinisi-robotics/kinisi_ros'?]
else [no candidate found or cache knows typed owner]
dl-->>User: [print git error text only]
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 25 25
Lines 3771 3771
=======================================
Hits 3517 3517
Misses 254 254 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts 0.1.2. The version lives in
rust/Cargo.toml's[workspace.package](thesingle source the publish workflow reads), so the bump plus the
Cargo.lockmember versions plus the changelog section is the whole release.
What ships
One user-facing change, #270:
dl kinisi/kinisi_roswhere the repository is
kinisi-robotics/kinisi_rosused to end at git's own sixlines — "Repository not found" plus four lines of access-rights advice — which
read identically to a permissions problem and named nothing to try instead. dl now
checks the same completion cache the shell completes from and adds one line:
Did you mean 'kinisi-robotics/kinisi_ros'?, carrying the branch back when thespec had one. Divergence row 29.
Narrow by construction: only a host's own not-found wording earns the line, only
from a clone step, and not when the cache also knows the repository under the owner
typed. git's text above it is unchanged in every case, so a machine with no
candidate in its cache sees exactly what it saw before.
One thing folded in
devlaunch-test-support'sversioned_with_the_workspaceasserts this crate'sinherited version against a literal, so it has to move with every release. The
0.1.1 bump left it at
"0.1.0"and no CI job caught it — therust-parityjobtests
devlaunch-runner,devlaunch-core,aidanddlby name and never thiscrate — so a developer's
cargo test --workspacehas been red since 0.1.1. Greenagain here.
Worth knowing rather than fixing silently: the test is a tripwire for this crate
tracking the workspace version, and it cannot read that version any way other than
the literal it compares against. It will need this same one-character edit at 0.1.3.
Verified
dl --versionreportsdl 0.1.2;cargo test --workspacegreen (test-supportincluded, for the first time since 0.1.1);
cargo fmt --checkclean.awkwas dry-run against this changelogsection — it extracts the
## [0.1.2]block and passes the non-empty gate.rust-parityande2eincluded.On merge,
publish.ymlsees the version change, builds the manylinux bin-wheel,publishes to PyPI, tags
v0.1.2and writes the release from the changelog;conda-publish.ymlchains off that tag.🤖 Generated with Claude Code
Summary by Sourcery
Release version 0.1.2 with the updated changelog and workspace package metadata.
Documentation:
Tests:
Chores: