Skip to content

Free an edit session's replaced buffers without a synchronous wait (#13943) - #13944

Closed
yasmoradi wants to merge 1 commit into
developfrom
yasmoradi/13943/bmage-dispose-without-sync-wait
Closed

yasmoradi wants to merge 1 commit into
developfrom
yasmoradi/13943/bmage-dispose-without-sync-wait

Conversation

@yasmoradi

Copy link
Copy Markdown
Member

closes #13943

DisposeWhenIdle no longer tries _renderLock.Wait(0) first. It always hands the buffers to DisposeAfterRenderAsync, which waits for the render lock asynchronously, so they are released as soon as no render reads them, as they already were when a render was running.

@yasmoradi
yasmoradi requested a review from msynk as a code owner October 18, 2026 21:09
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d1c06c1d-95b5-4632-ac6a-a920c528194b
📥 Commits

Reviewing files that changed from the base of the PR and between 7fb63fb and fee9e18.

📒 Files selected for processing: 1
  • src/Bmage/Bit.Bmage.Core/Editing/ImageEditSession.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yasmoradi yasmoradi changed the title Release an edit session's replaced buffers without a synchronous wait (#13943) Free an edit session's replaced buffers without a synchronous wait (#13943) Oct 18, 2026
@msynk msynk closed this Oct 21, 2026
@msynk

msynk commented Oct 21, 2026

Copy link
Copy Markdown
Member

resolved in #14025

@yasmoradi
yasmoradi deleted the yasmoradi/13943/bmage-dispose-without-sync-wait branch October 21, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BmageEditor throws PlatformNotSupportedException on .NET 11 WebAssembly when it is closed or given another image

2 participants