Retention: sweep polls past their window, and anonymous names nothing refers to - #3
Merged
Merged
Conversation
…nothing refers to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing in the store was ever deleted. Two windows now do it, both whole days, either
neverto switch off:WHICHDAY_RETENTION_AFTER_POLL_ENDS(5) — from the day a poll ended: its closing date, or the day locked in if that is later.WHICHDAY_RETENTION_DAYS(90) — fromcreated_at, reaching every poll whatever its state. Nothing survives it, including a poll still taking answers.The same 90 days drop
@whichday.anonymousnames once no poll refers to them. Provider addresses are never dropped.Deleting a poll deletes everything about it, so a saved link reads as a link to a poll that never existed — no view changed.
V3addsaccount.created_at; existing rows are stamped at migration time and get a full window from there.Verified: 208 tests, coverage gate met. Against a copy of a real V1+V2 database —
V3applied,validatepassed, and a 0-day window deleted 11 real polls.