feat(access)!: choose login or anonymous at deploy time - #2
Merged
Merged
Conversation
…ing-boot:run forks its JVM
…they were copied from
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whichday was login-only.
WHICHDAY_ACCESS_MODEnow picks one mode at deploy time.anonymous(the new default) — no provider, nothing to configure. You type a name,the link is the invitation, and a six-digit admin code is what gets an organizer back
in. No polls list, no invitees, no reminders, and nothing claims to know who hasn't
answered — because nothing does.
login— exactly as before. OIDC, invitees, the lot.Notes
application-login.propertiesand has to stay there: Bootfetches the issuer's discovery document at startup, so anonymous mode inheriting it
would hang on a provider it has no reason to reach.
PollService— three branches, nothing else knows there are twomodes.
Callercarries the admin code so the service stays free of session state.V2adds a nullableadmin_code, compared only against the poll you already hold thelink to, so no unique index.
/poll/:id/settleand can be cancelled. It could not be undone.