Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Desktop Sidebar: Remove "Home"  #1633

Description

@alexrcabral

Proposed Mockup

Mockup of v2 Mathshare sidebar on desktop. This shows a profile portrait with the initial A. Underneath is the name Alex C in bold, followed by Teacher, and Signout. The main portion of the sidebar is shown beneath. These options read My Solution Sets, My Created Sets, Example Sets, About Mathshare, Help Center, and Accessibility. My Created Sets is currently active, which is represented by bold, darker font.

In the list of linked options on the sidebar, "Home" should be removed since it doesn't provide anywhere to link separate from "My Sets". 

Reference

Style Guide: https://invis.io/CQYLLW8J49U
Fonts: https://www.dropbox.com/sh/c12m6ufweyds20d/AAAdXNPOt8e52DkSAr9pd-a-a/Fonts?dl=0

Acceptance criteria: 

Given that I'm a user who is on a screen wide enough to view the sidebar, I should no longer encounter the Home link as the first link. (My Solution Sets and My Created Sets should be first.) 

Activity

  1. added 2 commits that reference this issue on Jan 26, 2021
  2. abaranowska1 commented on Jan 26, 2021

    @abaranowska1

    @rupeshparab Probably the changes are not deployed on QA instance
    image

  3. rupeshparab commented on Jan 26, 2021

    @rupeshparab
    Collaborator

    @abaranowska1
    Its PR has been merged: https://github.com/benetech/MathShare/pull/1656/files
    I looked into the build notifications to check if build has failed, but it seems no build got trigerred today

    @johnhbenetech
    Can you check if there is any issue due to which build is not being triggered?

  4. rupeshparab commented on Jan 27, 2021

    @rupeshparab
    Collaborator

    @abaranowska1
    Changes have been deployed now

  5. abaranowska1 commented on Jan 27, 2021

    @abaranowska1

    @rupeshparab @alexrcabral
    Home link is not displayed as the first link - it was removed but My Solution Sets and My Created Sets should be first - now I see only My Sets
    image

  6. rupeshparab commented on Jan 27, 2021

    @rupeshparab
    Collaborator

    @abaranowska1
    there is a different task for change from My Sets to My Solution Sets and My Created Sets, I think we can track this change on it:
    #1636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions