Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the input normalization that
Pairsinherited fromStrSeqbefore the typing refactor. Currently,config['sources'].as_pairs()turnsfilesystem coverartinto one pair per character, bytes fail validation, and non-iterable values leakTypeErrorinstead ofConfigTypeError.Decode byte strings, split scalar strings on whitespace, and check that other inputs are iterable before converting the pairs. Preserve list, tuple, generator, and sequence-protocol inputs, plus existing defaults. Add regression tests and a changelog entry.
Validation on Python 3.12.14:
git diff --checkpassPrepared with OpenAI Codex assistance. The regression was reproduced locally against both current main and v2.1.0.