Handle ties and missing values in get.pc() - #108
Open
thierrygosselin wants to merge 1 commit into
Open
thierrygosselin wants to merge 1 commit into
thierrygosselin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
get.pc()return exactly one deterministic principal component for every requested marker while handling missing component scores correctly.Problems
get.pc()identifies the most strongly associated principal component using:When two or more components have the same maximum squared z-score,
which()returns multiple component indices. Assigning those indices into a single result position can cause recycling, truncation, warnings, or an output that is no longer aligned reliably with the requested markers.Missingness is also currently determined from PC1 alone. Consequently, a marker is skipped when its PC1 z-score is missing even if another component has a valid score.
Changes
NAonly when every component score for that marker is missing.Why deterministic tie handling is appropriate
get.pc()promises one principal component per marker. Returning the first maximum:which.max();The documented rule makes this limitation visible to users.
Validation
R CMD check --no-manual: 0 errors, 0 warnings, 0 notes when unavailable suggested packages were not forced.