Update PKCS12Test.java

[cragkhit]

We are researchers from Mahidol University, Thailand, and the State University of Ceará, Brazil, working on a research project for improving open-source projects by using the latest accepted answer from Stack Overflow that matched your code snippet. We found this recommendation for improving your code from https://stackoverflow.com/questions/40056844.

Note: Our study is approved by the Institutional Review Board of Mahidol University. You can find the participant information sheet explaining this study https://drive.google.com/file/d/1ml5AqrtWQ9pnifTQyTFTcWQmwp6RuPA7/view?usp=sharing.

Proposed change

Adding direct object comparison and a null check to avoid NullPointerException in the isEqual() method.

[peterdettman]

Thanks for the PR. I have instead removed this isEqual method and referenced org.bouncycastle.util.Arrays#areEqual instead.

[cragkhit]

Hi @peterdettman Thanks for considering our PR! We also found that the same change can be applied to the following methods as well. Just in case you also want to update them.

https://github.com/bcgit/bc-java/blob/main/prov/src/test/jdk1.3/org/bouncycastle/jce/provider/test/PSSTest.java (arrayEquals()): line 41-59
https://github.com/bcgit/bc-java/blob/main/prov/src/test/java/org/bouncycastle/jce/provider/test/PSSTest.java
(arrayEquals()): line 50-68
https://github.com/bcgit/bc-java/blob/main/prov/src/test/jdk1.1/org/bouncycastle/jce/provider/test/RSATest.java (arrayEquals()): line 53-77
https://github.com/bcgit/bc-java/blob/main/prov/src/test/jdk1.4/org/bouncycastle/jce/provider/test/DHTest.java (arrayEquals()): line 478-496
https://github.com/bcgit/bc-java/blob/main/prov/src/test/jdk1.4/org/bouncycastle/jce/provider/test/PSSTest.java (arrayEquals()): line 44-62
https://github.com/bcgit/bc-java/blob/main/prov/src/test/java/org/bouncycastle/jce/provider/test/FIPSDESTest.java (equalArray()): line 57-75
https://github.com/bcgit/bc-java/blob/main/prov/src/test/java/org/bouncycastle/jce/provider/test/DESedeTest.java (equalArray()): line 82-100

Hope this help!

[peterdettman]

OK, I cleaned up those others too, thanks again.