Main header doesn't include MemoryStream.hpp #4

Activity

1. bblanchon commented on Jul 18, 2019

   

   bblanchon

   on Jul 18, 2019

   Owner

   More actions

   Hi @skyhisi,

   MemoryStream is neither in the header nor in the documentation nor in the examples.
   I use this class in the tests, but I didn't want to publish it, because I'm pretty sure users will complain about its fixed capacity.

   @skyhisi, do you really use this class in your project?

   Best Regards,
   Benoit
2. skyhisi commented on Jul 18, 2019

   

   skyhisi

   on Jul 18, 2019

   Author

   More actions

   Hi Benoit,
   I found it whilst browsing the source, and it seems to work fine to me.

   My use case is to build up a string in memory with print to serialise up some data, before reading it out the buffer in blocks for sending over the network. I know the maximum size of the data I have, so a fixed size is fine for my use. Using MemoryStream was simpler than managing a buffer manually with sprintf and strcat 😃

   Something like:

   MemoryStream stream(512);
   stream.print(F("temperature="));
   stream.print(temperature);
   stream.print(F(",humidity="));
   stream.print(humidity);
   // ...
   char buf[64];
   while ((len = buffer.readBytes(buf, sizeof(buf))) != 0)
   {
     client.write((uint8_t*)buf, len);
   }

   If there's a better way of doing this, let me know.
   Thanks,
   Silas
3. bblanchon commented on Jul 18, 2019

   

   bblanchon

   on Jul 18, 2019

   Owner

   More actions

   Did you mean stream.readBytes() instead of buffer.readBytes()?

   If so, you probably want to use BufferingPrint, WriteBufferingStream, or WriteBufferingClient, because that's exactly what they do (assuming that client is an instance of Client).

   WriteBufferingClient bufferingClient(client, 64);
   bufferingClient.print(F("temperature="));
   bufferingClient.print(temperature);
   bufferingClient.print(F(",humidity="));
   bufferingClient.print(humidity);
   bufferingClient.flush();
4. skyhisi commented on Jul 18, 2019

   

   skyhisi

   on Jul 18, 2019

   Author

   More actions

   Yes, sorry I did mean stream.readBytes(), I was trying to simplify my code into the example and missed changing that.

   In this case, I'm not sure I can use the normal buffering classes, as I need to get the size of the complete buffer (I'm using available) before anything is sent to the client.

   My actual code is closer to this:

   PubSubClient mqttClient(/*...*/);
   
   void upload()
   {
     // ...
     MemoryStream influxLine(512);
     influxLine.print(F("weather "));
   
     influxLine.print(F("temperature="));
     influxLine.print(temperature);
     //...
   
     if (!mqttClient.beginPublish(TOPIC_PREFIX "/influx", influxLine.available(), true))
     {
       LOG("Failed to begin publish Influx update");
       goto exit;
     }
     while ((len = influxLine.readBytes(buf, 64)) != 0)
     {
       mqttClient.write((uint8_t*)buf, len);
     }
     if (!mqttClient.endPublish())
     {
       LOG("Failed to end publish Influx update");
       goto exit;
     }
   // ...

   Is there a better way to do this?
5. bblanchon commented on Jul 19, 2019

   

   bblanchon

   on Jul 19, 2019

   Owner

   More actions

   I would probably use sprintf_P() in a similar situation, but this is alright too.

   I think you're right: this class seems to be useful outside of my unit tests.
   As I told you, my main concern is that users will ask for an elastic capacity, so maybe I should rename it to FixedMemoryStream.
   What do you think?
6. skyhisi commented on Jul 19, 2019

   

   skyhisi

   on Jul 19, 2019

   Author

   More actions

   FixedMemoryStream is a good name. It allows in the future to have DynamicMemoryStream & StaticMemoryStream versions if required, which could be like the DynamicJsonDocument and StaticJsonDocument classes (variable size / compile time size).
7. bblanchon

   added

   enhancementNew feature or requestNew feature or request

   on Jul 20, 2019