Repository navigation
Feature request: Calculate statistics on a (wrapped) stream #24
Description
Could be interesting to be able to grab some stats of the stream usage:
- Total TX/RX bytes count
- Total TX/RX packets count (writes)
- Min/Max/Average read/write size
The only difficulty I see here: Some functions (i.e. readBytes) could be implemented via read() on some streams, but it can also be implemented directly by other implementations. Not sure if there's a clean way to handle it.
Activity
bblanchon commentedon Jun 23, 2022
Hi @vshymanskyy,
Thank you for this suggestion; I think this is a good idea.
We could name the new classes:
CountingPrintCountingStreamWriteCountingStreamReadCountingStreamThe members could be:
readBytes()readCount()minReadSize()maxReadSize()avgReadSize()writtenBytes()writeCount()minWriteSize()maxWriteSize()avgWriteSize()How does that sound?
Best regards,
Benoit
vshymanskyy commentedon Jun 24, 2022
Sounds cool. But some names may be ambiguous esp.
readBytes(). Maybe prefix all of them withtotal,min,max,avg?bblanchon commentedon Jun 26, 2022
You're right!
Maybe something like this, then:
readCount()writeCount()avgReadSize()avgWriteSize()maxReadSize()maxWriteSize()minReadSize()minWriteSize()totalReadSize()totalWriteSize()bblanchon commentedon Jun 27, 2022
I'm not sure how to handle error cases: should we count them, or ignore them?
For example, if upstream's
write()function returns0, should I incrementwriteCount? should I setminWriteSizeto0?dpharris commentedon Oct 23, 2022
Maybe readErrors() and writeErrors()?
mhaberler commentedon May 14, 2023
for such jobs I like the header-only stats classes by https://www.johndcook.com/blog/skewness_kurtosis/
he has several such classes on his website, real collectors items - I collect them here plus my adaptations: https://github.com/mhaberler/Stats