bumps idna to 3.15 and setuptools to 83.0.0 - #540
Merged
Merged
Conversation
Closes the two open Dependabot alerts that still apply to the development branch: - idna 3.11 -> 3.15: CVE-2026-45409 / GHSA-65pc-fj4g-8rjx, specially crafted input to idna.encode() bypasses the CVE-2024-3651 length check and consumes excessive CPU (medium, CVSS 5.3). - setuptools 82.0.1 -> 83.0.0: CVE-2026-59890 / GHSA-h35f-9h28-mq5c, MANIFEST.in exclusion bypass via NFC/NFD collision (medium, CVSS 6.1). setuptools 83 requires Python 3.10+, within the project's 3.13+ floor. The urllib3 and requests alerts reported against main are already resolved on development (2.7.0 and 2.34.2). Verified with a clean Python 3.14 environment built the way the Dockerfile does it (pip install -r requirements.txt, then vcf-sdk): pip-audit goes from 4 findings in 2 packages to none, only these two packages change in the resulting environment, the vSphere automation SDK imports and builds a client as before (pkg_resources is not needed by vmware-vapi-runtime 9.1.0.0 at runtime), and the unit tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two open Dependabot findings that still apply to
development:idna.encode()bypasses the CVE-2024-3651 length check and burns CPU (medium, CVSS 5.3)MANIFEST.inexclusion bypass via NFC/NFD collision (medium, CVSS 6.1)Changes:
requirements.txt, thesetuptoolspin inpyproject.toml, anduv.lockregenerated withuv lock --upgrade-packagefor just these two packages (the lock diff touches nothing else). setuptools 83 requires Python 3.10+, within the project's 3.13 floor.The urllib3 and requests alerts in the Dependabot tab are reported against
main(v1.8.1);developmentalready carries 2.7.0 and 2.34.2, so they close with the next release.Verification
pip install -r requirements.txt, thenpip install --upgrade vcf-sdk):pip-auditgoes from 4 findings in 2 packages (idna, setuptools) to none.pip freezebefore vs after differs in exactly these two packages.com.vmware.vapi.std_client,vmware.vapi.vsphere.client),vsphere_automation_sdk_availableisTrue, andcreate_vsphere_client()gets as far as the network call. Regarding VMware SDK import fails on Python 3.12+ with setuptools >= 82 (pkg_resourcesremoved) #497:vmware-vapi-runtime9.1.0.0 resolves versions throughimportlib.metadataand only falls back topkg_resourcesinside anexcept, so setuptools withoutpkg_resourcesis fine here (it already is ondevelopmentwith 82.0.1).docker build --platform linux/amd64of the Dockerfile with these pins succeeds; inside the image: setuptools 83.0.0, idna 3.15, urllib3 2.7.0, requests 2.34.2, the SDK import works,netbox-sync.py --helpruns, andpip-auditover the image's installed packages reports no known vulnerabilities.