Repository navigation
Convert make_rpm to argparse and add an initial test for it. - #75
Merged
Merged
Conversation
aiuto
commented
Aug 9, 2019
| def CallRpmBuild(self, dirname): | ||
| """Call rpmbuild with the correct arguments.""" | ||
|
|
||
| buildroot = os.path.join(dirname, RpmBuilder.BUILD_DIR) |
Collaborator
Author
There was a problem hiding this comment.
This is the only interesting part of the change. It changes --builtroot from /BUILDROOT to /BUILD. Without that, it was not finding any of my sources. I think this is actually a manifestation of pkg_rpm being built for an old version of rpmbuild and rpmbiuld changing under it. That points to the fragility of the rule.
brandjon
approved these changes
Aug 15, 2019
brandjon
left a comment
brandjon
left a comment
Member
There was a problem hiding this comment.
Not too familiar with this but LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49
There are two things going on here.
While testing, I think I discovered a latent bug in the tool, w.r.t. BUILDROOT, so I had to fix that to make any pkg_rpm() instance build. Regardless of that issue, the change to argparse is what this PR is about. If it turns out there is still flakiness w.r.t. BUILDROOT, we can fix that as a distinct issue.