Skip to content

Create an example of the kind of link tree Node users must create - #603

Merged
aiuto merged 8 commits into
bazelbuild:mainfrom
aiuto:rellink
Sep 13, 2022
Merged

aiuto merged 8 commits into
bazelbuild:mainfrom
aiuto:rellink

Conversation

@aiuto

@aiuto aiuto commented Jul 20, 2022 •

Copy link
Copy Markdown
Collaborator

This just creates the tool to make the kind of test data that simulates an NPM treey.

See #115 for context.

@aiuto
aiuto requested a review from nacl as a code owner July 20, 2022 03:43
@aiuto
aiuto marked this pull request as draft July 20, 2022 03:43
@aiuto aiuto changed the title Create an example of the kind of link tree Node users muse create Create an example of the kind of link tree Node users must create Jul 26, 2022
@aiuto
aiuto marked this pull request as ready for review August 4, 2022 14:48
@aiuto
aiuto requested a review from jylinv0 August 30, 2022 21:46
@aiuto
aiuto requested a review from cgrindel September 9, 2022 19:07

@cgrindel cgrindel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of questions in the review comment.

Comment thread pkg/private/pkg_files.bzl Outdated
Comment thread tests/util/defs.bzl
Comment thread tests/util/defs.bzl Outdated
@aiuto
aiuto merged commit 46eabd3 into bazelbuild:main Sep 13, 2022
@aiuto

aiuto commented Sep 13, 2022

Copy link
Copy Markdown
Collaborator Author

Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants