Repository navigation
pkg_deb: compute Installed-Size automatically when unset - #1079
Closed
chouquette wants to merge 1 commit into
Closed
chouquette wants to merge 1 commit into
chouquette wants to merge 1 commit into
Conversation
The `Installed-Size` control field can be set through the `installed_size` attribute, but it requires knowing the package size ahead of time and hardcoding it, which is unpractical. This is likely to cause the attribute to be omitted and the installed size metadata to be missing. This commit now automatically computes the installed size when the attribute is not explicitly provided.
chouquette
force-pushed
the
installed-size-auto-compute
branch
from
September 17, 2026 12:28
f33e3f7 to
c355a4b
Compare
chouquette
marked this pull request as ready for review
September 17, 2026 12:28
chouquette
requested review from
aiuto,
cgrindel and
dannysullivan
as code owners
September 17, 2026 12:28
Collaborator
|
I think what I would rather see is the size (and checksums?) being a side effect output the tarball maker. |
Collaborator
|
This is what I have been thinking about w.r.t. improving the performance. I should have wrote this a half a year ago, when I first realized I needed to go there. |
Contributor
Author
|
Superseded by #1083 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Installed-Sizecontrol field can be set through theinstalled_sizeattribute, but it requires knowing the package size ahead of time and hardcoding it, which is unpractical.This is likely to cause the attribute to be omitted and the installed size metadata to be missing.
This PR now automatically computes the installed size when the attribute is not explicitly provided.