Skip to content

Add bash completion conffile to debian packages - #808

Open
jwnimmer-tri wants to merge 1 commit into
bazelbuild:masterfrom
jwnimmer-tri:deb-bash-completion
Open

jwnimmer-tri wants to merge 1 commit into
bazelbuild:masterfrom
jwnimmer-tri:deb-bash-completion

Conversation

@jwnimmer-tri

Copy link
Copy Markdown
Contributor

No description provided.

@jwnimmer-tri

Copy link
Copy Markdown
Contributor Author

This is an improvement upon #563, so I'll ping @fweikert for review, please?

Comment thread deb/BUILD
],
env = {
"HOME": "/tmp",
"USE_BAZEL_VERSION": "9.2.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace with latest to avoid this becoming stale

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream (bazel) completion script doesn't change that often, so I don't think staleness is a huge concern. (Previously, users would install this conffile by hand, so it would necessarily become stale since it was a manual process to refresh it.)

I do think this should be pinned to an exact version, so that bazelisk releases are reproducible when rebuilt from the same tag. That seems more important than possible staleness.

I'm open to suggestions on how we could (via docs and/or automation and/or CI scripting) encourage this pin to be keep somewhat current.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants