pre-compile is failing for binary targets if there is no main specified

[aignas]

With #2768 optional, it is possible to have zero .py files or the main is not used or specify main_module.

Then I get errors:

                providers = py_executable_impl(
        File "/home/ignas-anikevicius/.cache/bazel/_bazel_ignas-anikevicius/e1764a0ec8835154284d951e9bb11b85/external/rules_python+/python/private/py_executable.bzl", line 256, column 35, in py_executable_impl
                return py_executable_base_impl(
        File "/home/ignas-anikevicius/.cache/bazel/_bazel_ignas-anikevicius/e1764a0ec8835154284d951e9bb11b85/external/rules_python+/python/private/py_executable.bzl", line 1049, column 50, in py_executable_base_impl
                main_py = precompile_result.py_to_pyc_map[main_py]
Error: key None not found in dictionary

It seems that we may have forgotten to handle the main_module in precompilation.

[brandonchinn178]

I'm seeing the following error when just specifying main_module on 1.5.0

Traceback (most recent call last):
        File "/private/var/tmp/_bazel_bchinn/a36d21e5d31520c078520e02826ccfa8/external/rules_python+/python/private/py_test_rule.bzl", line 25, column 35, in _py_test_impl
                providers = py_executable_impl(
        File "/private/var/tmp/_bazel_bchinn/a36d21e5d31520c078520e02826ccfa8/external/rules_python+/python/private/py_executable.bzl", line 255, column 35, in py_executable_impl
                return py_executable_base_impl(
        File "/private/var/tmp/_bazel_bchinn/a36d21e5d31520c078520e02826ccfa8/external/rules_python+/python/private/py_executable.bzl", line 1140, column 46, in py_executable_base_impl
                exec_result = semantics.create_executable(
        File "/private/var/tmp/_bazel_bchinn/a36d21e5d31520c078520e02826ccfa8/external/rules_python+/python/private/py_executable.bzl", line 365, column 33, in _create_executable
                _create_stage1_bootstrap(
        File "/private/var/tmp/_bazel_bchinn/a36d21e5d31520c078520e02826ccfa8/external/rules_python+/python/private/py_executable.bzl", line 858, column 68, in _create_stage1_bootstrap
                subs["%main%"] = "{}/{}".format(ctx.workspace_name, main_py.short_path)
Error: 'NoneType' value has no field or method 'short_path'

[andrew-helm]

I am seeing the same error as @brandonchinn178 . Additionally though the docs state otherwise, I am having to pass a non-empty list in the srcs parameter. If I don't, I get missing value for mandatory attribute 'srcs' in 'py_binary' rule

Here is my minimal target:

py_binary(
    name = "server_main",
    srcs = [
        "server.py",
    ],
    main_module = "gunicorn",
    deps = [
        ":server",
    ],
)

Where :server is like:

py_library(
    name = "server",
    srcs = [
        "server.py",
    ],
    deps = [
        py_require("fastapi"),
        py_require("gunicorn"),
    ],
)

[brandonchinn178]

Might be fixed by #3072