Repository navigation
Fix in IdzipWriter.write when writing a buffer larger than a single member - #7
Merged
Merged
Conversation
… single member when using IdzipWriter
…llocation of bytestrings when reading large numbers of chunks
…tes not evenly divisible by MAX_MEMBER_SIZE
Owner
|
thanks for the pr. Looks good. Let me run it against current prod data for a while and I'll merge it in |
Contributor
Author
|
Thanks. It was working just fine before until I tried to push a 13 GB file through it without calling flush at any point (not my standard workflow). |
bauman
approved these changes
May 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
IdzipWriter, theinput_buffermay grow to the point where it will no longer fit inside a single member. This leads to thesyncoperation failing when it fails with an assertion error in_write_extra_field