Skip to content

Stabilize frontend readiness type-generation by pinning setuptools - #983

Merged
vncero merged 6 commits into
mainfrom
copilot/fix-frontend-linting-checks
Oct 29, 2026
Merged

vncero merged 6 commits into
mainfrom
copilot/fix-frontend-linting-checks

Conversation

Copilot AI commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

The Frontend linting / readiness checks CI job failed in the type-generation step (generate_types.sh) when Django schema generation crashed on ModuleNotFoundError: No module named 'pkg_resources'. This was caused by environment resolution pulling a setuptools version that no longer provides pkg_resources.

  • Root cause addressed

    • Ensure the conda env used by CI/frontend readiness keeps pkg_resources available for manage.py spectacular and transitive Google Cloud imports.
  • Dependency constraint update

    • Updated environment-dev.yml to pin setuptools below the breaking boundary:
      dependencies:
        - python=3.10
        - setuptools<81
  • Impact

    • Unblocks ./frontend/generate_types.sh in CI readiness checks without changing application/runtime logic.

Co-authored-by: bmatvey <68698370+bmatvey@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job for frontend linting Stabilize frontend readiness type-generation by pinning setuptools Oct 24, 2026
Copilot AI requested a review from bmatvey October 24, 2026 00:53

@bmatvey bmatvey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully fixes CI checks. version issue fixed.

Co-authored-by: bmatvey <68698370+bmatvey@users.noreply.github.com>
Co-authored-by: bmatvey <68698370+bmatvey@users.noreply.github.com>

@bmatvey bmatvey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should fix it locally, but will not work as a long term fix

Co-authored-by: bmatvey <68698370+bmatvey@users.noreply.github.com>
Copilot AI requested a review from bmatvey October 24, 2026 01:28

@bmatvey bmatvey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is lowkey stupid but maybe it will pass ci now

Co-authored-by: bmatvey <68698370+bmatvey@users.noreply.github.com>
Copilot AI requested a review from bmatvey October 28, 2026 15:50

@bmatvey bmatvey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this at least should fix this CI error

@bmatvey
bmatvey marked this pull request as ready for review October 28, 2026 16:00
@vncero
vncero self-requested a review October 28, 2026 18:31


def upload_image(raw_image, image_path):
from PIL import Image

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is definitely sus, long-term fix is probably update things correctly. will merge to fix ci.

@vncero
vncero merged commit 3bb7e5b into main Oct 29, 2026
3 checks passed
@vncero
vncero deleted the copilot/fix-frontend-linting-checks branch October 29, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants