Close atomic JSON write symlink window - #88
Closed
codeforester wants to merge 1 commit into
Closed
codeforester wants to merge 1 commit into
codeforester wants to merge 1 commit into
Conversation
codeforester
marked this pull request as ready for review
August 5, 2026 00:04
Contributor
Author
|
Recreating on the issue's enhancement branch category so branch policy matches #62. |
codeforester
deleted the
security/62-20260804-atomic-write-symlink-window
branch
August 5, 2026 00:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the redundant post-replacement permission rewrite from atomic JSON writes. The temporary file is already created with private permissions and synced before replacement, so re-opening the destination by path is unnecessary and could create a symlink-swap window.
Validation
.venv/bin/python -m pytest -q tests/test_run_bundle_retention.py tests/test_app_run_metadata.py tests/test_app_log_retention.pygit diff --checkFollow-up hardening for #86/#62.